-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arguments tests for cl_khr_command_buffer_mutable_dispatch. #1749
Conversation
Signed-off-by: Paweł Jastrzębski <[email protected]>
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
… arguments test. Applied review comments for mutable dispatch global arguments test: - clFinish to ensure command-buffer has finished executing for calling clUpdateMutableCommandsKHR - Add second clEnqueueCommandBufferKHR for the command-buffer again before calling clEnqueueReadBuffer so that the kernel runs with the new argument Signed-off-by: Paweł Jastrzębski <[email protected]>
…tch arguments test. Applied review comments for remaining mutable dispatch arguments test: - clFinish to ensure command-buffer has finished executing for calling clUpdateMutableCommandsKHR Signed-off-by: Paweł Jastrzębski <[email protected]>
Signed-off-by: Paweł Jastrzębski <[email protected]>
Signed-off-by: Paweł Jastrzębski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a bunch of fixes to these tests as a PR to your branch here: pj87#1. Can you check that the fixes were incorporated even if you don't merge the PR? It seems like a lof the issues still remain.
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Paweł Jastrzębski <[email protected]>
Signed-off-by: Paweł Jastrzębski <[email protected]>
Signed-off-by: Paweł Jastrzębski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing the tests pass apart from SVM
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
/* Set the arguments */ | ||
error = clSetKernelArg(kernel, 0, sizeof(cl_mem), &streams[0]); | ||
test_error(error, "Unable to set indexed kernel arguments"); | ||
error = clSetKernelArg(kernel, 1, sizeof(cl_mem) * 2, nullptr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why sizeof(cl_mem) * 2
number of bytes of local data rather than based on numberOfInts
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
Changes made: - Remove unneeded headers - Remove unneeded variable - Remove unneeded skip condition - Fix type int -> cl_int Signed-off-by: Paweł Jastrzębski <[email protected]>
Signed-off-by: Paweł Jastrzębski <[email protected]>
Signed-off-by: Paweł Jastrzębski <[email protected]>
Signed-off-by: Paweł Jastrzębski <[email protected]>
Signed-off-by: Paweł Jastrzębski <[email protected]>
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Paweł Jastrzębski <[email protected]>
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Paweł Jastrzębski <[email protected]>
Signed-off-by: Paweł Jastrzębski <[email protected]>
Signed-off-by: Paweł Jastrzębski <[email protected]>
Signed-off-by: Paweł Jastrzębski <[email protected]>
...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Paweł Jastrzębski <[email protected]>
Signed-off-by: Paweł Jastrzębski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging as discussed in the July 11th teleconference.
No description provided.