Add global size tests for cl_khr_command_buffer_mutable_dispatch. #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paweł Jastrzębski <[email protected]>
EwanC
reviewed
May 29, 2023
...cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_global_size.cpp
Outdated
Show resolved
Hide resolved
We should check that's some observable output from the kernel as a result of the change to global work size, not just that clGetMutableCommandInfoKHR has been updated. For example, getting every work-item to call get_global_size() inside of the kernel and writing it to a buffer, then reading the buffer after the command-buffer enqueue has finished and check it matches what we expect. Signed-off-by: Paweł Jastrzębski <[email protected]>
EwanC
reviewed
May 31, 2023
...cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_global_size.cpp
Show resolved
Hide resolved
...cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_global_size.cpp
Outdated
Show resolved
Hide resolved
Applied review comments for mutable dispatch global arguments test: - clFinish to ensure command-buffer has finished executing for calling clUpdateMutableCommandsKHR - Change variable and constant names for global size Signed-off-by: Paweł Jastrzębski <[email protected]>
Changes made: - Fix skip conditions - Remove obsolete variable - Replace a variable with a constant Signed-off-by: Paweł Jastrzębski <[email protected]>
bashbaug
reviewed
Jun 13, 2023
...cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_global_size.cpp
Outdated
Show resolved
Hide resolved
Comment on lines
171
to
174
| size_t info_global_size = 0; | ||
| const size_t update_global_size = 3; | ||
| const size_t sizeToAllocate = 64; | ||
| const size_t num_elements = sizeToAllocate / sizeof(cl_int); |
There was a problem hiding this comment.
Nitpick: I think these variables are only used inside of Run - do they need to be class member variables?
There was a problem hiding this comment.
I decided to put it there for more tidy code, since they are mostly consts.
Changes made: - Remove explicit base class call - Fix condition check - Fix constant magic number Signed-off-by: Paweł Jastrzębski <[email protected]>
Signed-off-by: Paweł Jastrzębski <[email protected]>
EwanC
previously approved these changes
Jun 27, 2023
EwanC
previously approved these changes
Jun 30, 2023
...cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_global_size.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Paweł Jastrzębski <[email protected]>
EwanC
previously approved these changes
Jul 3, 2023
21 tasks
EwanC
approved these changes
Jul 11, 2023
bashbaug
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.