Circumvent pipe buffer deadlock #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 76.96% 77.58% +0.61%
==========================================
Files 11 11
Lines 725 736 +11
==========================================
+ Hits 558 571 +13
+ Misses 167 165 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fingolfin
approved these changes
Aug 24, 2023
|
Confirmed fix. Thank you!!! |
fingolfin
reviewed
Aug 24, 2023
lgoettgens
commented
Aug 24, 2023
fingolfin
reviewed
Aug 24, 2023
| strout = String(read(out)) | ||
| strerr = String(read(err)) | ||
| strout = read(outfile, String) | ||
| strerr = read(errfile, String) |
There was a problem hiding this comment.
should we rm(outfile) and rm(errfile)?
There was a problem hiding this comment.
ok we can also just leave it as is, fine by me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #165.
@fingolfin please check that on your machine as well.
This should be backported to 0.6.6 and released, as it should occur for every package with many (>150 ambiguities).