Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do-block in mktemp in _find_ambiguities #168

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Aug 25, 2023

The do-block form ensures that the files are automatically closed

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #168 (64547be) into master (c6fab8a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   77.58%   77.58%           
=======================================
  Files          11       11           
  Lines         736      736           
=======================================
  Hits          571      571           
  Misses        165      165           
Flag Coverage Δ
unittests 77.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/ambiguities.jl 89.43% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lgoettgens
Copy link
Collaborator

Thanks for the PR! I didn't think about this when working on #166.

@fingolfin this change should be backported to 0.6.x

@fingolfin fingolfin merged commit b115769 into JuliaTesting:master Aug 25, 2023
@jishnub jishnub deleted the mktempdoblock branch August 25, 2023 15:38
@lgoettgens
Copy link
Collaborator

@fingolfin this change should be backported to 0.6.x

Bump

@fingolfin
Copy link
Member

I have no interest in investing time in maintaining the 0.6.x branch; and this is a tiny annoyance at best, not a serious bug fix

@lgoettgens
Copy link
Collaborator

I have no interest in investing time in maintaining the 0.6.x branch; and this is a tiny annoyance at best, not a serious bug fix

ok, that's a decision I am more than fine with

lgoettgens pushed a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants