-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jans-cedarling): Make SparKV use generics, and update MemoryLogger to use those. #10593
Conversation
05137be
to
ff8f658
Compare
Signed-off-by: John Anderson <[email protected]>
…V storage type. Signed-off-by: John Anderson <[email protected]>
Signed-off-by: John Anderson <[email protected]>
…or more efficient pop_logs Signed-off-by: John Anderson <[email protected]>
Signed-off-by: John Anderson <[email protected]>
…ient pop_logs Signed-off-by: John Anderson <[email protected]>
Signed-off-by: John Anderson <[email protected]>
Signed-off-by: John Anderson <[email protected]>
Signed-off-by: John Anderson <[email protected]>
Signed-off-by: John Anderson <[email protected]>
Signed-off-by: John Anderson <[email protected]>
Signed-off-by: John Anderson <[email protected]>
Signed-off-by: John Anderson <[email protected]>
Signed-off-by: John Anderson <[email protected]>
Signed-off-by: John Anderson <[email protected]>
…:Value conversions Signed-off-by: John Anderson <[email protected]>
…ation constructors Signed-off-by: John Anderson <[email protected]>
Signed-off-by: John Anderson <[email protected]>
ff8f658
to
bbbb1c5
Compare
Signed-off-by: John Anderson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like you to use cargo fmt
formatter
cargo fmt -p sparkv
Signed-off-by: John Anderson <[email protected]>
Signed-off-by: John Anderson <[email protected]>
Signed-off-by: John Anderson <[email protected]>
|
Signed-off-by: John Anderson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think fallback
logger no need initialize every time. But in current context it doesn't really matter.
Prepare
Depends on #10013
Description
Target issue
#10554
closes #10554
Implementation Details
Make SparKV use a generic to specify the type to be stored.
Update
MemoryLogger
to make use of SparKV with generics.Provide a
drain
iterator for a fast implementation ofMemoryLogger::pop_logs
.Update
LogStorage
andLogWriter
to useserde_json::Value
internally.Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.