Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (jans-cedarling): Update sparkv to use Generics #10554

Closed
nynymike opened this issue Jan 6, 2025 · 1 comment · Fixed by #10593
Closed

feat (jans-cedarling): Update sparkv to use Generics #10554

nynymike opened this issue Jan 6, 2025 · 1 comment · Fixed by #10593
Assignees
@djellemah @moabu
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement
Milestone
1.3.0

Comments

@nynymike
Copy link
Contributor

nynymike commented Jan 6, 2025

It would be great to update the API to use generics. This would allow using serde_json::Value directly as a storage value, avoiding the need to deserialize from a string when retrieving the value.
@olehbozhok
Copy link
Contributor

We can start to do it after #10013

@djellemah djellemah assigned djellemah and unassigned olehbozhok Jan 7, 2025
@djellemah djellemah added the comp-jans-cedarling Touching folder /jans-cedarling label Jan 7, 2025
@djellemah djellemah mentioned this issue Jan 13, 2025
Merged
6 tasks
@djellemah djellemah linked a pull request Jan 13, 2025 that will close this issue
feat(jans-cedarling): Make SparKV use generics, and update MemoryLogger to use those. #10593
Merged
6 tasks
@moabu moabu added this to the next release milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djellemah djellemah

@moabu moabu

Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement
Projects
None yet
Milestone
1.3.0
4 participants
@djellemah @nynymike @olehbozhok @moabu