Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a base file #33

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add a base file #33

wants to merge 6 commits into from

Conversation

beckyjackson
Copy link
Collaborator

Resolves #32

@beckyjackson
Copy link
Collaborator Author

make test passes locally on my machine, so I'm not sure what's going on... I'm passing mro-import.owl as the input to the template and just not merging it, so it should be able to find all import labels...

@beckyjackson
Copy link
Collaborator Author

I'll come back & update this after #34 gets merged in.

@beckyjackson beckyjackson marked this pull request as draft August 27, 2020 20:48
This was referenced Sep 1, 2020
Closed
Merged
@beckyjackson beckyjackson marked this pull request as ready for review March 9, 2021 17:01
jamesaoverton
jamesaoverton requested changes Mar 9, 2021
View reviewed changes
Copy link
Collaborator

@jamesaoverton jamesaoverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have looked more closely at this six months ago.

The base file should not be reasoned: "The base file contains all and only native axioms. No further manipulation is performed, in particular no reasoning, redundancy stripping or relaxation." https://github.com/INCATools/ontology-development-kit/blob/master/docs/ReleaseArtefacts.md#release-artefact-1-base-required And I would prefer not to use robot remove anyway.

Instead I want to build the base file just by including everything except external.tsv. It would be interesting to compare that to what you get with the approach you're using in 50081a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesaoverton jamesaoverton jamesaoverton requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a "base" file
2 participants
@beckyjackson @jamesaoverton