-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMGT & release updates #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
I'm happy with this. Let's wait to hear from Randi and then merge. |
Thanks @acrinklaw. @beckyjackson please take it from here. |
This is good to go. I think we just need to wait on Randi to review the new files, correct? |
I will review them today. I am finishing up some training for our two new
curators & then I'll do MRO next.
…On Tue, Sep 29, 2020 at 2:53 PM Becky Jackson ***@***.***> wrote:
This is good to go. I think we just need to wait on Randi to review the
new files, correct?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#39 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKDY42TVKD6W3TXV27CKLLSIJJLZANCNFSM4QR24YYA>
.
--
Randi Vita, M.D.
Lead Ontology and Quality Manager
Immune Epitope Database and Analysis Project
La Jolla Institute for Allergy & Immunology
9420 Athena Circle
La Jolla, Ca 92037
[email protected]
www.immuneepitope.org
858-752-6912
|
We should:
|
This is Randi-approved and has passed the automated validation. @jamesaoverton could you take a quick look when you get a chance so we can get this merged in? |
jamesaoverton
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes Austin's IMGT updates and an update to the release process. I made a clean branch to get rid of the history of the "big" MRO.
Note that we are waiting on Jason to confirm that this is OK with him, but I've added a
make release
task that creates two files to attach to a release:mro.owl
iedb.zip
- contains the five IEDB_TARGETSmro.owl
and those five IEDB_TARGETS are removed from the repository.I guess we will also want to attach
mro-base.owl
from #33 so let's figure this out first.