Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to environment variable configurations for ibm zos core 1.10 compatibility #252

Merged
merged 41 commits into from
Sep 16, 2024

Conversation

ketankelkar
Copy link
Member

@ketankelkar ketankelkar commented Apr 9, 2024

The ibm_zos_core collection version 1.10 brings with it a migration to ZOAU version 1.3.x. The new version of ZOAU packages the zoautil_py library files differently than version 1.2.x. Correctly configuring the PYTHONPATH variable is all that is needed for continued support of both old and new.

To adopt the new as well as continue backwards compatibility in these playbooks with ZOAU version 1.2.x and ibm_zos_core collection version 1.9, a number of changes are introduced through this PR.

  • In inventories/host_vars/all.yml:
    • The value of PYTHONPATH is now a variable that is defined/configured in group_vars/zos_host.yml.
  • In inventories/group_vars/zos_host.yml:
    • A new variable PYZ_VERSION is introduced to track the version of python. This info is needed to select the correct ZOAU python library
    • A new variable ZOAU_PYTHONPATH is introduced (with 3 variations) to point to the ZOAU zoautil_py python library files.
      • the first variation covers the wheel installation method.
      • the second variation covers the pre-compiled binaries method for version 1.3.x.
      • the third variation covers the pre-compiled binaries method for version 1.2.x.

@ketankelkar ketankelkar marked this pull request as ready for review April 29, 2024 23:35
@ketankelkar ketankelkar self-assigned this Apr 29, 2024
@ketankelkar ketankelkar requested a review from ddimatos April 29, 2024 23:36
Copy link
Member

@richp405 richp405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor questions, not issues. One old date, and a question about versioning of python.

Signed-off-by: Ketan Kelkar <[email protected]>
@ketankelkar ketankelkar force-pushed the updates-for-ibm_zos_core_1.10_compatibility branch from f322d13 to 7a5ca6b Compare September 4, 2024 17:34
Copy link
Member

@ddimatos ddimatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ketankelkar nice work, I had a few comments for you, I did not comment on each reoccurring change but my comments apply to many of the redundant content.

docs/share/zos_core/configuration_guide.md Show resolved Hide resolved
docs/share/zos_core/configure_host_vars.md Show resolved Hide resolved
docs/share/zos_core/configuration_guide.md Outdated Show resolved Hide resolved
zos_basics/constructs/inventories/host_vars/zos_host.yml Outdated Show resolved Hide resolved
zos_basics/constructs/inventories/host_vars/zos_host.yml Outdated Show resolved Hide resolved
zos_basics/constructs/inventories/host_vars/zos_host.yml Outdated Show resolved Hide resolved
Copy link
Member

@ddimatos ddimatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the added updates @ketankelkar , looks good.

@ketankelkar ketankelkar merged commit b1d9cda into main Sep 16, 2024
3 checks passed
@ketankelkar ketankelkar deleted the updates-for-ibm_zos_core_1.10_compatibility branch September 16, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants