[Enable][1618]create_gdg_playbooks_into_respository #277
Conversation
AndreMarcel99
requested review from
ketankelkar,
rexemin,
fernandofloresg,
ddimatos and
richp405
There was a problem hiding this comment.
I'd like you to check those odd error messages.... usually that's a warning that something (path?) is mis-configured. It's funny that the errors come up about not accessing the file it is showing. Maybe you could change 1 line in each file to force a rescan, the error MIGHT solve itself.
|
@richp405 the line of import required to be the name of the yml |
| @@ -0,0 +1,89 @@ | |||
| # Create add edit copy and fetch with Generation data group | |||
| This playbook demonstrates how to create a GDG edit copy and fetch | |||
There was a problem hiding this comment.
Maybe rework this into:
This playbook demonstrates how to create, edit, copy and fetch Generation Data Groups (GDG) and Generation Datasets (GDS).
| # | {{ tmp_data_set }} | ||
| # | - Using zos_data_set, create first generation of the GDG. | ||
| # | - Using zos_data_set, create second generation of the GDG. | ||
| # | - Using zos_blockinfile, to add the logs to the last creation of the GDG. |
There was a problem hiding this comment.
Rework the second sentence:
add the logs to the latest generation.
| # | - Using zos_data_set, create first generation of the GDG. | ||
| # | - Using zos_data_set, create second generation of the GDG. | ||
| # | - Using zos_blockinfile, to add the logs to the last creation of the GDG. | ||
| # | - Using zos_copy, to copy content of last creation to first creation of GDG. |
There was a problem hiding this comment.
Rework this to:
Using zos_copy, copy the content from the latest generation to a previous one.
| # | - Using zos_data_set, create second generation of the GDG. | ||
| # | - Using zos_blockinfile, to add the logs to the last creation of the GDG. | ||
| # | - Using zos_copy, to copy content of last creation to first creation of GDG. | ||
| # | - Using zos_lineinfile, add comment to first creation of GDG with relative |
There was a problem hiding this comment.
And here rework it to:
Using zos_lineinfile, add a comment to a previous generation of the GDG using relative notation.
| # | - Using zos_copy, to copy content of last creation to first creation of GDG. | ||
| # | - Using zos_lineinfile, add comment to first creation of GDG with relative | ||
| # | notation {{ tmp_data_set }}(-1). | ||
| # | - Using zos_fetch, to fetch the first creation of the GDG. |
There was a problem hiding this comment.
Change first creation to previous generation
|
@AndreMarcel99 - I will start with the general comments.
I see this in 2 READMEs
|
|
@AndreMarcel99 - this is not your doing, but we have a PR that will change how the environment variables are configured which is recommends users start adopting wheels, the PR is here, #252, I don't recall why we did not merge it yet , but @ketankelkar who owns the PR should be aware that if your PR merges first he will have extra work , or if his goes first , you will have some additional work. We are at a inflection point which happens, so we need you two to figure this out @ketankelkar , thank you. See Ketan's reply, basically go forward with the commit and we can update later. |
|
@AndreMarcel99 the main README which is organized by topics has no link to your GDG use cases, users will not know to find them. 
Maybe the simple solution is to make an entry like This comment also applies to the second playbook. Update: 10/16/24 - I still don't see the README has any reference to this content, see the readme it makes no mention of these 2 playbooks, how will users find them if they are not part of the table of contents? |
|
This is more personal preference because we organize by topics, you could have also put these directly under instead of: Again, just personal preference. |
|
@ddimatos under zos_concepts or data_transfer? |
zos_concepts/gdg_datasets/create_copy_submit/create_copy_submit.yml
Outdated
Show resolved
Hide resolved
zos_concepts/gdg_datasets/create_copy_submit/create_copy_submit.yml
Outdated
Show resolved
Hide resolved
zos_concepts/gdg_datasets/create_copy_submit/create_copy_submit.yml
Outdated
Show resolved
Hide resolved
Lets just leave it as is, the Sites table of contents in the main readme don't care where you place things, at this point this PR has lots of other important points to address. |
zos_concepts/gdg_datasets/create_copy_submit/create_copy_submit.yml
Outdated
Show resolved
Hide resolved
zos_concepts/gdg_datasets/create_copy_submit/create_copy_submit.yml
Outdated
Show resolved
Hide resolved
AndreMarcel99
deleted the
enabler/1618/create_gdg_playbooks_into_respository
branch
SUMMARY
Add playbooks about cases to works with gds.
ISSUE TYPE