Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always print pimitive fields in json output. #149

Merged
merged 1 commit into from
Nov 20, 2023
Merged

always print pimitive fields in json output. #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/libCli/MessageFormatterJson.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ namespace cli
std::string resultString;
google::protobuf::util::JsonPrintOptions printOptions;
printOptions.preserve_proto_field_names = true;

// Will print primitive fields regardless of their values. So e.g. an int32 field set to 0 will not be omitted.
printOptions.always_print_primitive_fields = true;

google::protobuf::util::Status status = google::protobuf::util::MessageToJsonString(f_message, &resultString, printOptions);
if(not status.ok())
{
Expand Down
2 changes: 1 addition & 1 deletion tests/functionTests/rpcExecutionTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ RPC succeeded :D
#START_TEST json_output_number_map
@@CMD@@ --jsonOutput --disableCache 127.0.0.1 examples.NestedTypeRpcs returnNestedMixedEmpty
/.* Received message:
{"empty_child":{}}
{"some_integer":0,"empty_child":{}}
RPC succeeded :D
#END_TEST

Expand Down
Loading