Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always print pimitive fields in json output. #149

Merged
merged 1 commit into from
Nov 20, 2023
Merged

always print pimitive fields in json output. #149

merged 1 commit into from
Nov 20, 2023

Conversation

abb3r
Copy link

@abb3r abb3r commented Nov 20, 2023

No description provided.

ericboehmler
ericboehmler approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@ericboehmler ericboehmler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@ericboehmler
Copy link
Member

Hi @rainerschoe - this fix Rahman did helps us printing json with some primitive fields being zero, which is valid and important data in many cases.

rainerschoe
rainerschoe approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@rainerschoe rainerschoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, This could actually be considered a bugfix :P

@rainerschoe rainerschoe merged commit 6bacb9a into IBM:master Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericboehmler ericboehmler ericboehmler approved these changes

@rainerschoe rainerschoe rainerschoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abb3r @ericboehmler @rainerschoe