Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add activation fn registry system #34

Merged
merged 14 commits into from
Apr 16, 2024
Merged

Conversation

HyperCodec
Copy link
Owner

Allows for activation functions to be registered so that the deserialization step can work with other types of activation fns.

Update activation fn branch
@HyperCodec HyperCodec added the enhancement New feature or request label Apr 15, 2024
@HyperCodec HyperCodec self-assigned this Apr 15, 2024
@HyperCodec
Copy link
Owner Author

HyperCodec commented Apr 15, 2024

for some reason the macro wants to compile error now and I'm not sure what changed to make it start erroring when it didn't before

@HyperCodec
Copy link
Owner Author

^ maybe ambiguous commit names by accident but the first one solved some of the annoying stuff with the macro and the second one fixed rayon feature compile errors

@HyperCodec
Copy link
Owner Author

This technically works but still want to make sure it is able to access and use the registry when generating/mutating and maybe do the "separate flag" thing from #17

@HyperCodec
Copy link
Owner Author

HyperCodec commented Apr 16, 2024

The problem with the current activation functions system is the macro uses the path passed to it and directly stringifies it, probably want something more like the full typepath of the function to prevent some ambiguous user errors.

@HyperCodec
Copy link
Owner Author

The ActivationScope::INPUT and ActivationScope::OUTPUT flags are currently not really used, as I am manually assigning the activation during generation and not changing it anywhere except hidden layer. This may change in the future.

@HyperCodec
Copy link
Owner Author

Everything looks good, the serde test passes, so I think I can merge.

@HyperCodec HyperCodec merged commit 69929cb into dev Apr 16, 2024
3 checks passed
@HyperCodec HyperCodec deleted the 17-activation-fn-registry branch April 16, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

topology module extrapolation [TODO] activation fn registry
1 participant