-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add activation fn registry system #34
Conversation
Update activation fn branch
for some reason the macro wants to compile error now and I'm not sure what changed to make it start erroring when it didn't before |
^ maybe ambiguous commit names by accident but the first one solved some of the annoying stuff with the macro and the second one fixed rayon feature compile errors |
This technically works but still want to make sure it is able to access and use the registry when generating/mutating and maybe do the "separate flag" thing from #17 |
The problem with the current activation functions system is the macro uses the path passed to it and directly stringifies it, probably want something more like the full typepath of the function to prevent some ambiguous user errors. |
The |
Everything looks good, the serde test passes, so I think I can merge. |
Allows for activation functions to be registered so that the deserialization step can work with other types of activation fns.