Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] activation fn registry #17

Closed
HyperCodec opened this issue Feb 22, 2024 · 2 comments · Fixed by #34
Closed

[TODO] activation fn registry #17

HyperCodec opened this issue Feb 22, 2024 · 2 comments · Fixed by #34
Assignees
Labels
enhancement New feature or request

Comments

@HyperCodec
Copy link
Owner

While the most widely-used activation functions are predefined, it'd be better to have some sort of registry so that the serde deserialization works with custom activations.

It would also be good to note that there should be a separate flag or something for those activation functions which do not want to be randomly mutated to/fro.

@HyperCodec HyperCodec added the enhancement New feature or request label Feb 22, 2024
@HyperCodec HyperCodec self-assigned this Feb 22, 2024
@HyperCodec
Copy link
Owner Author

hmm this seems impractical to implement. delaying.

@HyperCodec
Copy link
Owner Author

HyperCodec commented Apr 15, 2024

Might implement this using a trait or something and then just boxing it. The current Arc<dyn Fn> model could be very easily replaced by Arc<dyn Activation> and then blanket impl on Fn for some default trait stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant