Invites & sharing Room URL use Web Share API if available #6508
+174
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's a screenshot of the new Share room link using the Web Share API.
And here's one possibility of what might result |
|
PinkPolygonSoup has said the wording is fine. |
|
That completes the changes from today's dev meeting. Now that we have testing by other people, I think this is ready to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing is an additional option, when available. It works as expected on Firefox and Chrome on MacOS, Oculus Browser on Quest, Safari on iOS and Chrome on Android. As noted earlier, many platforms only pass the URL to destination, or just the URL and title.
Implements #6507
There's an image with this code on Docker Hub: dougreeder/hubsfirst:v1