HUD Invite button: fixes by calling Web Share API directly #6510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That completes the changes from today's dev meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The in-world Invite button is currently broken, because it emits the "action_invite" event, but the handler is removed along with the rest of the 2-D UI, when entering immersive mode.
As the user can always copy the Invite URL/Room URL when in 2-D mode, I'm assuming the in-world Invite button should be a quick shortcut. Therefore, I have wired it up to call the Web Share API directly. This reduces the friction of inviting someone to join you when in immersive mode in a headset, thus advancing our goal of making it easy for multiple people to join one instance.
Tested on a Quest 3.
This PR is dependent on #6508