Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.23, [email protected] 1.22.6 (new formula) #175310

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Jun 21, 2024

Announcements:

Release notes: https://go.dev/doc/go1.23

Go 1.23 milestone: GitHub milestone details

Go 1.23 release dashboard: https://dev.golang.org/release

Downloads: https://go.dev/dl/

Related previous:

Build logs:


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. labels Jun 21, 2024
@p-linnane p-linnane added the pre-release Artifact is pre-release label Jun 21, 2024
@p-linnane
Copy link
Member

@stefanb Let me know when you want the no-fail-fast label here.

@stefanb
Copy link
Member Author

stefanb commented Jun 21, 2024

@p-linnane, please add the no-fail-fast label, or whatever is needed to not abort the builds after the first failure.
Perhaps also long build (or something similar) label will be needed.
Thanks!

@p-linnane p-linnane added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. labels Jun 21, 2024
@chenrui333 chenrui333 added CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner long dependent tests Set a long timeout for dependent testing labels Jun 21, 2024
@chenrui333
Copy link
Member

need to have long build jobs for deps (cancelled and re-ran)

This was referenced Jun 25, 2024
stefanb added a commit to stefanb/homebrew-core that referenced this pull request Jun 30, 2024
The version tag 0.36.0 was likely moved as
* Homebrew#172577 was created on May 23rd
* release https://github.com/gruntwork-io/cloud-nuke/releases/tag/v0.36.0 was tagged on May 24th

See also:
* Upstream issue: gruntwork-io/cloud-nuke#707
* Homebrew#175310
@nikaro nikaro mentioned this pull request Aug 17, 2024
6 tasks
nikaro added a commit to nikaro/homebrew-core that referenced this pull request Aug 17, 2024
Since go1.23 has been released in Homebrew and govulncheck was build with go1.22 it cannot work anymore.

```
/opt/homebrew/Cellar/go/1.23.0/libexec/src/slices/iter.go:50:17: cannot range over seq (variable of type iter.Seq[E])
-: This application uses version go1.22 of the source-processing packages but runs version go1.23 of 'go list'. It may fail to process source files that rely on newer language features. If so, rebuild the application using a newer version of Go.
/opt/homebrew/Cellar/go/1.23.0/libexec/src/maps/iter.go:51:20: cannot range over seq (variable of type iter.Seq2[K, V])
-: This application uses version go1.22 of the source-processing packages but runs version go1.23 of 'go list'. It may fail to process source files that rely on newer language features. If so, rebuild the application using a newer version of Go.
```

Ping Homebrew#175310
@nikaro nikaro mentioned this pull request Aug 17, 2024
6 tasks
nikaro added a commit to nikaro/homebrew-core that referenced this pull request Aug 17, 2024
Since go1.23 has been released in Homebrew and golangci-lint was build with go1.22 it cannot work anymore.

Ping Homebrew#175310
@nikaro nikaro mentioned this pull request Aug 17, 2024
6 tasks
stefanb added a commit that referenced this pull request Aug 17, 2024
use "go" again after hofstadter-io/hof#391 is fixed and released

Follow-up to:

* #175310
stefanb added a commit that referenced this pull request Aug 17, 2024
use "go" againg after kudobuilder/kuttl#546 is fixed and released

Follow-up to #175310
stefanb added a commit that referenced this pull request Aug 18, 2024
use "go" again after goccy/bigquery-emulator#348 is fixed and released

follow-up after #175310
stefanb added a commit that referenced this pull request Aug 20, 2024
Tor project migrated their git from gitolite to gitlab, see
* https://blog.torproject.org/gitolite-gitlab-migration/
* https://x.com/torproject/status/1785726621972115962

So instead of the source code the old url https://gitweb.torproject.org/pluggable-transports/meek.git/snapshot/meek-0.38.0.tar.gz returns a redirect to a webpage with different checksum

URL remapping is defined in https://archive.torproject.org/websites/gitolite2gitlab.txt
with line:
pluggable-transports/meek tpo/anti-censorship/pluggable-transports/meek

Follow-up to #175310
@stefanb stefanb mentioned this pull request Aug 20, 2024
6 tasks
stefanb added a commit that referenced this pull request Aug 20, 2024
use "go" again after nxtrace/NTrace-core#247 is fixed and released

Follow-up to #175310
@stefanb stefanb mentioned this pull request Aug 28, 2024
stefanb added a commit that referenced this pull request Aug 28, 2024
use "go" again after vitessio/vitess#16015 is fixed and released

Follow-up to #175310
stefanb added a commit that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long dependent tests Set a long timeout for dependent testing new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.