Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Go 1.23, which doesn't allow //go:linkname to internal symbols, including to runtime package #74

Closed
stefanb opened this issue Jun 25, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@stefanb
Copy link

stefanb commented Jun 25, 2024

While testing Go 1.23 rc1 in

there was an error:

  # github.com/gotranspile/cxgo/cmd/cxgo
  link: github.com/gotranspile/cxgo/runtime/libc: invalid reference to runtime.findnull

Go 1.23 no longer allows //go:linkname * runtime.* link instructioins, see

It is used several times in
https://github.com/gotranspile/cxgo/blob/29871598a6a289a52f5c92cfc3da031b8aa1ce6b/runtime/libc/runtime.go

@dennwc dennwc added the bug Something isn't working label Jun 25, 2024
@dennwc dennwc self-assigned this Jun 25, 2024
@dennwc
Copy link
Contributor

dennwc commented Jun 25, 2024

Yeah, it should have happened sooner or later. Will fix it. Thank you for the early notice!

@dennwc dennwc closed this as completed in 9a8147e Jul 1, 2024
@stefanb
Copy link
Author

stefanb commented Jul 1, 2024

Please don't forget to tag a release sometime before Go 1.23 is released in August.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants