Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore TAG_CHANGES in BOARD_VISUAL_STATE=2 TRIGGER blocks #16

Merged
merged 1 commit into from
Oct 28, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions hslog/filter.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,6 @@ class BattlegroundsLogFilter(Iterable):
- All options messages (from DebugPrintOptions) are discarded
- Blacklisted and unknown tags for FULL_ENTITY and SHOW_ENTITY messages are discarded
- TAG_CHANGES containing blacklisted and unknown tags are discarded
- All TAG_CHANGES that are part of a TRIGGER block that include a BOARD_VISUAL_STATE=2
tag change are discarded
- All TAG_CHANGES that precede a BOARD_VISUAL_STATE=1 tag change in a TRIGGER block are
discarded
"""
Expand Down Expand Up @@ -392,9 +390,6 @@ def _handle_tag_change(self, msg: str, line: str):
buf.should_skip = True
self._current_buffer.buffer[i] = buf

if value == "2":
setattr(self._current_buffer, "skip_tag_changes", True)

return

# If we're already buffering a DEATHS block, then changing the PLAYER_TECH_LEVEL
Expand Down
Loading