Restore TAG_CHANGES in BOARD_VISUAL_STATE=2 TRIGGER blocks #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's some logic in the filter to strip out tag changes that share a TRIGGER block with a tag change that sets BOARD_VISUAL_STATE to 2. We believe that for some time now, BOARD_VISUAL_STATEs 1 or 2 are related to shop manipulation code and not part of what we want to capture in combat. However! In a recent BGS log, there are tag changes that seem to represent enchantments (i.e., ATK and HEALTH buffs) being applied to entities in a BOARD_VISUAL_STATE=2 block; whereas in older BGS logs, that happens in a separate block. This change removes the logic that was stripping all BOARD_VISUAL_STATE=2 block tag changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some logic in the filter to strip out tag changes that share a TRIGGER block with a tag change that sets BOARD_VISUAL_STATE to 2. We believe that for some time now, BOARD_VISUAL_STATEs 1 or 2 are related to shop manipulation code and not part of what we want to capture in combat.
However! In a recent BGS log, there are tag changes that seem to represent enchantments (i.e., ATK and HEALTH buffs) being applied to entities in a BOARD_VISUAL_STATE=2 block; whereas in older BGS logs, that happens in a separate block.
This change removes the logic that was stripping all BOARD_VISUAL_STATE=2 block tag changes.