Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: remove unused FY column from CAN Table #3419

Merged
merged 3 commits into from
Feb 5, 2025
Merged

style: remove unused FY column from CAN Table #3419

merged 3 commits into from
Feb 5, 2025
+0 −9

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Feb 4, 2025 •
edited
Loading

What changed

  • remove FY from table heading and table row in CANs Table
image

Issue

#3330

How to test

  1. e2e tests pass

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [ ] Form validations updated

@fpigeonjr fpigeonjr added the UX task UX-team related tasks and to-dos label Feb 4, 2025
@fpigeonjr fpigeonjr self-assigned this Feb 4, 2025
@fpigeonjr fpigeonjr linked an issue Feb 4, 2025 that may be closed by this pull request
Design Debt for FY Column on CANs List #3330
Closed
3 tasks
@jonnalley
Copy link
Contributor

Plz don’t merge yet @fpigeonjr. I’d like to use this as an experiment

@fpigeonjr
Copy link
Contributor Author

rgr, I will standby on merge (still needs review)

kimschulke
kimschulke reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@kimschulke kimschulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! This should clear up any confusion between Appropriation FY and Budget FY, while still enabling the BT to see which CAN is oldest/should be used first by referencing the Obligate By column. Future testing and UX feedback can help us improve further as needed

@kimschulke kimschulke self-requested a review February 5, 2025 13:41
@fpigeonjr
Copy link
Contributor Author

ok @jonnalley, PR is ready to be merged in when you are ready

@fpigeonjr fpigeonjr assigned jonnalley and unassigned fpigeonjr and kimschulke Feb 5, 2025
@fpigeonjr fpigeonjr merged commit faa8eaf into main Feb 5, 2025
42 checks passed
@fpigeonjr fpigeonjr deleted the collab/table_updates branch February 5, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimschulke kimschulke kimschulke approved these changes

@maiyerlee maiyerlee maiyerlee approved these changes

@rajohnson90 rajohnson90 rajohnson90 approved these changes

@johndeange johndeange Awaiting requested review from johndeange

@npage123 npage123 Awaiting requested review from npage123

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

@jonnalley jonnalley Awaiting requested review from jonnalley

@devops-chris devops-chris Awaiting requested review from devops-chris

Assignees

@jonnalley jonnalley

Labels
UX task UX-team related tasks and to-dos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design Debt for FY Column on CANs List
5 participants
@fpigeonjr @jonnalley @rajohnson90 @maiyerlee @kimschulke