Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to choose the Pantheon organization during bootstrapping #657

Merged
merged 6 commits into from
May 18, 2024
Merged

Ability to choose the Pantheon organization during bootstrapping #657

merged 6 commits into from
May 18, 2024

Conversation

AronNovak
Copy link
Member

@AronNovak
Copy link
Member Author 

 [notice] Logged in via machine token.
 [Exec] Done in 0.634s
 [Exec] Running terminus org:list --format=json
 [Exec] Done in 0.433s

 Select a Pantheon organization::
  [13532bc5-3a16-44b6-99c4-abc] Org1
  [4aba616c-cbd2-4dc3-abec-def] Gizra - Org1
  [7c901be9-46f6-4b09-93b3-tgh] Gizra - Org2

@AronNovak AronNovak requested a review from amitaibu April 15, 2024 13:23
amitaibu
amitaibu reviewed Apr 15, 2024
View reviewed changes
Copy link
Member

@amitaibu amitaibu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

robo-components/BootstrapTrait.php Show resolved Hide resolved
robo-components/BootstrapTrait.php Outdated Show resolved Hide resolved
AronNovak and others added 2 commits April 15, 2024 21:53
@AronNovak
code review points
190745e
@AronNovak
Site install process fixes during bootstrap (#659)
9b2990a 
* fix site install process

* provide default settings

* fix lock status message

* fix docker mirror setup

* Update robo-components/DeploymentTrait.php

* phpcs
@AronNovak AronNovak requested a review from amitaibu April 17, 2024 03:47
@AronNovak
Copy link
Member Author

Ready to go?

amitaibu
amitaibu approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@amitaibu amitaibu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@amitaibu amitaibu merged commit c5932e3 into main May 18, 2024
1 check passed
@amitaibu amitaibu deleted the 656-choose-org-bootstrap branch May 18, 2024 19:16
@GizraNotifier GizraNotifier mentioned this pull request May 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitaibu amitaibu amitaibu approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AronNovak @amitaibu