Update documentation to match changes of IGN #3840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #7736 ↗︎
Details:
Review all test suite changes for PR #3840 ↗︎ |
|||||||||||||||
babastienne
commented
Dec 1, 2023
babastienne
force-pushed
the
update_ign
branch
from
09f235e to
f9c3f29
Compare
|
@submarcos je veux bien un coup de main sur cette PR ? Pas certain de bien voir pourquoi il y a des tests qui sont KO. Si jamais tu as quelques instants (toi ou quelqu'un d'autre) je veux bien que vous repreniez ce travail pendant mon absence. Merci 🙏 |
|
@babastienne c'est surement le changement d'ordre des fonds de plan le soucis. Il vaut mieux separer les modifs, une PR pour la doc, une pour les trads, une pour l'ordre par defaut des fonds de plan |
Chatewgne
force-pushed
the
update_ign
branch
5 times, most recently
from
71d0a23 to
237d800
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3840 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 292 292
Lines 22048 22048
=======================================
Hits 21684 21684
Misses 364 364 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
I have added tests that prove my fix is effective or that my feature works.New and existing unit tests pass locally with my changesMy commits are all using prefix convention (emoji + tag name) and references associated issuesThe title of my PR mentionned the issue associated