Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Issue 112: add a click handler on the submit button and favicon #115

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pherris
Copy link

@pherris pherris commented Apr 1, 2021

add a click handler on the submit button and favicon

Screen Shot 2021-04-01 at 10 31 11 AM

paired with @jeffledin

@pherris pherris mentioned this pull request Apr 1, 2021
@paulproteus
Copy link

Hi @pherris ! I'm just an Internet rando, not a maintainer of the project. I did notice that GItHub reports a conflict on this pull request, which may make the maintainers of the project concerned.

It seems that the conflict is a non-issue; however, you need to use "git rebase" or something similar to squash all these commits into 1 before GitHub will acknowledge that the conflict is a non-issue.

Hoping to be helpful; feedback welcome. Best, Asheesh.

@pherris
Copy link
Author

pherris commented Apr 2, 2021

Thanks @paulproteus - merge conflict fixed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants