Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #255 - 온보딩 쪽에 있던 메모리 이슈 해결 #259

Merged
merged 2 commits into from
May 16, 2024
Merged

[Fix] #255 - 온보딩 쪽에 있던 메모리 이슈 해결 #259

merged 2 commits into from
May 16, 2024

Conversation

seongmin221
Copy link
Contributor

🌁 Background

온보딩에서 확인한 unfreed memory 문제가 있었습니다

👩‍💻 Contents

  • @jeongdung-eo 과의 탐구로 onboardingVC 쪽 closure에 weak self 가 적용되어 있지 않은 문제를 해결했습니다

📝 Review Note

  • 추가적으로, UI 코드는 main queue 에서만 만져야 한다는 warning이 자꾸 떠서 같이 반영했습니다

📣 Related Issue

📬 Reference

@seongmin221 seongmin221 requested a review from jeongdung-eo May 13, 2024 15:01
@seongmin221 seongmin221 self-assigned this May 13, 2024
jeongdung-eo
jeongdung-eo approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@jeongdung-eo jeongdung-eo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳임다
instruments 툴에서 제공하는 여러가지 기능들 하나씩 사용해봅시당

@seongmin221 seongmin221 merged commit 0c97928 into develop May 16, 2024
1 check failed
@seongmin221 seongmin221 deleted the fix/#255-memory-issue-at-onboarding branch May 16, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongdung-eo jeongdung-eo jeongdung-eo approved these changes

Assignees

@seongmin221 seongmin221

Labels
🍏 성민 🍏 🍒 정은 🍒 🧊 Fix
Projects
None yet
Milestone
No milestone
2 participants
@seongmin221 @jeongdung-eo