Merge pull request #259 from GEON-PPANG/fix/#255-memory-issue-at-onbo…

…arding [Fix] #255 - 온보딩 쪽에 있던 메모리 이슈 해결
GEON-PPANG · May 16, 2024 · 0c97928 · 0c97928
2 parents 47665de + 1e31d60
commit 0c97928
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 107 deletions.
diff --git a/GEON-PPANG-iOS.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/GEON-PPANG-iOS.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
diff --git a/GEON-PPANG-iOS/Presentation/Common/BottomSheet/LoginRequiredViewController.swift b/GEON-PPANG-iOS/Presentation/Common/BottomSheet/LoginRequiredViewController.swift
@@ -278,7 +278,6 @@ extension LoginRequiredViewController: ASAuthorizationControllerDelegate {
                     nickname: ""
                 )
 
-                guard let presenting = self.presentingViewController as? UINavigationController else { return }
                 self.postSignUp(with: request, viewController: self) { role in
                     KeychainService.setKeychain(of: .role, with: role)
                     self.dismiss(animated: true) {
@@ -288,6 +287,7 @@ extension LoginRequiredViewController: ASAuthorizationControllerDelegate {
                             }
                         } else {
                             DispatchQueue.main.async {
+                                guard let presenting = self.presentingViewController as? UINavigationController else { return }
                                 Utils.push(presenting, NickNameViewController())
                             }
                         }

diff --git a/...PANG-iOS/Presentation/Scene/Auth/Onboarding/ViewController/OnboardingViewController.swift b/...PANG-iOS/Presentation/Scene/Auth/Onboarding/ViewController/OnboardingViewController.swift
@@ -306,9 +306,9 @@ extension OnboardingViewController: ASAuthorizationControllerDelegate {
                     nickname: ""
                 )
 
-                self.postSignUp(with: request) { role in
+                self.postSignUp(with: request) { [weak self] role in
                     KeychainService.setKeychain(of: .role, with: role)
-                    self.check(role: role)
+                    self?.check(role: role)
                 }
 
             case .revoked: