Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stripping DOI URL prefix for sources #593

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Stripping DOI URL prefix for sources #593

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cec157e
Added URL stripping to gradeable environment creation
jamesbraza Oct 16, 2024
9c8df8c
Moved to reuse DocDetails.DOI_URL_FORMATS instead of regex
jamesbraza Oct 16, 2024
c73634a
Moved the regex link to DocDetails to centralize
jamesbraza Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions paperqa/agents/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from abc import ABC
from collections.abc import Awaitable, Callable, Sequence
from enum import StrEnum
from typing import TYPE_CHECKING, assert_never
from typing import TYPE_CHECKING, ClassVar, assert_never

from aviary.env import ENV_REGISTRY, TASK_DATASET_REGISTRY, Frame, TaskDataset
from aviary.message import Message
Expand Down Expand Up @@ -277,12 +277,23 @@ def __init__(
else:
assert_never(split)

# SEE: https://regex101.com/r/lpF1up/1
DOI_URL_REGEX_PATTERN: ClassVar[str] = r"https?:\/\/(?:dx\.)?doi\.org\/"

def get_new_env_by_idx(self, idx: int) -> GradablePaperQAEnvironment:
sources = []
for s in self.data.iloc[idx].sources:
match = re.split(self.DOI_URL_REGEX_PATTERN, string=s, maxsplit=1)
if len(match) != 2 or match[0]: # noqa: PLR2004
raise NotImplementedError(
f"Didn't handle DOI extraction from source {s!r}."
)
sources.append(match[1])
return self._make_gradable_environment(
ideal=self.data.iloc[idx].ideal,
distractors=self.data.iloc[idx].distractors,
question=self.data.iloc[idx].question,
sources=list(self.data.iloc[idx].sources),
sources=sources,
)

def __len__(self) -> int:
Expand Down
Loading