Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripping DOI URL prefix for sources #593

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Stripping DOI URL prefix for sources #593

merged 3 commits into from
Oct 16, 2024

Conversation

jamesbraza
Copy link
Collaborator

This enables us to directly compare on DOI downstream

@jamesbraza jamesbraza added the bug Something isn't working label Oct 16, 2024
@jamesbraza jamesbraza self-assigned this Oct 16, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Oct 16, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 16, 2024
@mskarlin
Copy link
Collaborator

fwiw I think DOIs always via the following URLS (from our DocDetails class):

DOI_URL_FORMATS: ClassVar[Collection[str]] = {
"https://doi.org/",
"http://dx.doi.org/",
}

@jamesbraza
Copy link
Collaborator Author

fwiw I think DOIs always via the following URLS (from our DocDetails class):

DOI_URL_FORMATS: ClassVar[Collection[str]] = { "doi.org", "http://dx.doi.org", }

Didn't know about that, just moved to use it 👌

@jamesbraza jamesbraza merged commit 2744606 into main Oct 16, 2024
3 of 5 checks passed
@jamesbraza jamesbraza deleted the stripping-doi branch October 16, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants