-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle Unknown
transactions, blocks and consensus parameters
#2154
Open
hal3e
wants to merge
38
commits into
master
Choose a base branch
from
hal3e/unknown-variants
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hal3e
changed the title
support
support Sep 2, 2024
Unknowon
transaction typeUnknown
transaction type
16 tasks
hal3e
force-pushed
the
hal3e/unknown-variants
branch
from
September 3, 2024 20:14
752bfb9
to
df9f96d
Compare
hal3e
changed the title
support
feat: handle Sep 18, 2024
Unknown
transaction typeUnknown
transactions and consensus parameters
hal3e
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
September 18, 2024 09:34
MitchTurner
reviewed
Sep 18, 2024
MitchTurner
previously approved these changes
Sep 19, 2024
hal3e
changed the title
feat: handle
feat: handle Sep 23, 2024
Unknown
transactions and consensus parametersUnknown
transactions, blocks and consensus parameters
xgreenx
reviewed
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
FuelLabs/fuels-rs#1477
Description
Refactored code to handle
Unknown
transaction types,ConsensusParameters
andBlocks
.For transactions I have craeted a new
TransactionType
that we cantry_into
thefuel_tx::Transaction
.For
ConsesnsuParameters
andBlock
I have usedcynic's
fallback
attrbute and added aUnknown
variant for allVersion
enums.I had to bump
cynic
to3.1.0
andreqwest
to0.12.0
to use thefallback
attribute on enums.Note: I have not added tests for the changes in the endpoints. I was not sure how that should be done.
BREAKING CHANGES:
graphql
endpoints for transactions use the newTransactionType
type instead offuel_tx::Transaction
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]