feat!: gracefully handle unknown transaction variants #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hal3e
changed the title
|
@hal3e, can you please sync the branch with master and then change the base branch from master to |
…ount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` (#1498) # Release notes In this release, we: - Move `get_asset_outputs_for_amount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` # Summary This PR moves `get_asset_outputs_for_amount`, `get_asset_inputs_for_amount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` trait. It seem that these two methods doesn't require a full `Account` and so it give more flexibility in order to implement them in other structures such as `Wallet`. Now `Wallet` also implement these two methods. Before you were forced to build a `WalletUnlocked` even if you don't use the `secret_key`. # Breaking changes This contains an API breaking change as some public trait as been edited: # Breaking Changes The provider option flag `cacheUtxo` was renamed to `resourceCacheTTL` ```rust // before use fuels::acounts::Account; wallet.get_asset_outputs_for_amount(...); ``` ```rust // after use fuels::acounts::ViewOnlyAccount; wallet.get_asset_outputs_for_amount(...); ``` # Checklist - [x] All **changes** are **covered** by **tests** (or not applicable) - [x] All **changes** are **documented** (or not applicable) - [x] I **reviewed** the **entire PR** myself (preferably, on GH UI) - [x] I **described** all **Breaking Changes** (or there's none) --------- Co-authored-by: hal3e <[email protected]> Co-authored-by: Rodrigo Araújo <[email protected]> Co-authored-by: MujkicA <[email protected]>
hal3e
requested review from
digorithm,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1477
Release notes
In this release, we:
will be added later
Summary
fuels-rsis usingfuel-core-clientto communicate with the node.fuel-core-client:TransactoinTypeenum with anUnknownvariant tofuel-core-client.Unknownvariants toConsensusParametersand all of its fields.cynicwill fallback to this variant.fuel-corePR: FuelLabs/fuel-core#2154Checklist:
transaction:
fuel-core-clientTransactionTypewith theUnknownvariant infuel-core-clientfuels-rscoin-type:
fuels-rsfuel-core-clientalready has anUnknownvariant - refactorfuels-rsconsensus-parameters:
fuel-core-clientUnknownvariants to all the version enumsblock and headers:
fuel-core-clientUnknownvariants to all the version enumsopcodes - INVESTIGATE
Breaking Changes
Unknownvariant toTransactionTypeandCoinTypeChecklist