Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new wallet support input password and silent options #201

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: new wallet support input password and silent options #201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1de50e
feat: new wallet support input password and silent options
lispking Sep 10, 2024
60d035b
rename password_non_interactive to unsafe_password
lispking Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions src/new.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,22 @@ pub struct New {
/// How many accounts to cache by default (Default 10)
#[clap(short, long)]
pub cache_accounts: Option<usize>,

/// Directly provide the wallet password when create new wallet.
///
/// WARNING: This is primarily provided for non-interactive testing. Using this flag is
/// prone to leaving your password exposed in your shell command history!
#[clap(short, long)]
pub unsafe_password: Option<String>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree that this should be a command line argument. I think we should support an environment variable, but a CLI argument is too easily leaked.


/// Silent mode, do not display the mnemonic phrase.
#[clap(short, long)]
pub silent: bool,
}

pub fn new_wallet_cli(wallet_path: &Path, new: New) -> anyhow::Result<()> {
ensure_no_wallet_exists(wallet_path, new.force, stdin().lock())?;
let password = request_new_password();
let password = new.unsafe_password.unwrap_or_else(request_new_password);
// Generate a random mnemonic phrase.
let mnemonic = generate_mnemonic_phrase(&mut rand::thread_rng(), 24)?;
write_wallet_from_mnemonic_and_password(wallet_path, &mnemonic, &password)?;
Expand All @@ -35,9 +46,12 @@ pub fn new_wallet_cli(wallet_path: &Path, new: New) -> anyhow::Result<()> {
)?;

let mnemonic_string = format!("Wallet mnemonic phrase: {mnemonic}\n");
display_string_discreetly(
&mnemonic_string,
"### Do not share or lose this mnemonic phrase! Press any key to complete. ###",
)?;

if !new.silent {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the tracing crate to control verbosity.

display_string_discreetly(
&mnemonic_string,
"### Do not share or lose this mnemonic phrase! Press any key to complete. ###",
)?;
}
Ok(())
}