feat: new wallet support input password and silent options #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sdankel
requested changes
Sep 11, 2024
| "### Do not share or lose this mnemonic phrase! Press any key to complete. ###", | ||
| )?; | ||
|
|
||
| if !new.silent { |
There was a problem hiding this comment.
We should use the tracing crate to control verbosity.
| /// WARNING: This is primarily provided for non-interactive testing. Using this flag is | ||
| /// prone to leaving your password exposed in your shell command history! | ||
| #[clap(short, long)] | ||
| pub unsafe_password: Option<String>, |
There was a problem hiding this comment.
I don't agree that this should be a command line argument. I think we should support an environment variable, but a CLI argument is too easily leaked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#202