Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): Create split SPAs #1059
feat(lambda): Create split SPAs #1059
Changes from all commits
913a52c
000b553
4508cac
2e9a427
83f8839
e65da1c
19992a6
048b091
0fa8543
4805e7c
d6490e7
33372ed
5cc3ab7
af2292a
aaa4ca4
0ac9739
f8a22c2
e1fb35f
2472b32
0325b22
7771b76
83e96f9
e67222b
ff1f1e3
4dc1c82
6e953c8
c5d7ab0
5230203
9a5cdad
8c20893
0157327
723e162
15a65a9
cbd5bba
1c61dc9
d0de3c0
1d6c96c
8df846c
7a109ec
0614c16
dd43f02
0df0678
0986323
05a145b
a383819
8e7fd3c
1e12fd2
5dd8135
d95f0e4
222b860
7851592
b567d50
749f159
b1a1eaa
48f83c7
228b08c
7555130
3d4af3c
670f68a
2b132e5
96b7073
4edbfd9
33f835e
2e6d724
af412e6
cf01a04
c9697e5
33e6045
3292ccd
516f3d7
dc61b29
061c83a
3547aca
6033628
1987dfc
8ca08d2
6b6fce0
793068d
629cb7e
6f1b0b3
8407bc6
75e80e1
04f9c20
1cc0423
48b4822
933dbb6
6754110
6593357
576e228
98f710d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check failure on line 15 in lib/lambda/submit/submitSplitSPA.ts
GitHub Actions / coverage-report
lambda/submit/submitSplitSPA.test.ts > handler > should fail to split a package with no topic name
Check failure on line 15 in lib/lambda/submit/submitSplitSPA.ts
GitHub Actions / test
lambda/submit/submitSplitSPA.test.ts > handler > should fail to split a package with no topic name
Check failure on line 15 in lib/lambda/submit/submitSplitSPA.ts
GitHub Actions / test
lambda/submit/submitSplitSPA.test.ts > handler > should fail to split a package with no topic name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good comment 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this essentially allow the schema to be a wildcard? Any sort of data can be passed and accepted
Check warning on line 68 in react-app/src/features/package/admin-changes/index.tsx
GitHub Actions / lint