-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): Create split SPAs #1059
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiffanyvu
temporarily deployed
to
split-spas-app
January 28, 2025 22:16 — with
GitHub Actions
Inactive
tiffanyvu
had a problem deploying
to
split-spas
January 28, 2025 22:21 — with
GitHub Actions
Failure
tiffanyvu
had a problem deploying
to
split-spas
January 28, 2025 22:24 — with
GitHub Actions
Failure
tiffanyvu
temporarily deployed
to
split-spas-kibana
January 28, 2025 22:24 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
split-spas-app
January 28, 2025 22:24 — with
GitHub Actions
Inactive
tiffanyvu
had a problem deploying
to
split-spas
January 28, 2025 22:27 — with
GitHub Actions
Failure
tiffanyvu
had a problem deploying
to
split-spas
January 28, 2025 22:31 — with
GitHub Actions
Failure
tiffanyvu
had a problem deploying
to
new-split-spas
January 28, 2025 22:42 — with
GitHub Actions
Failure
tiffanyvu
temporarily deployed
to
new-split-spas
January 28, 2025 22:42 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
new-split-spas
January 28, 2025 22:55 — with
GitHub Actions
Inactive
tiffanyvu
had a problem deploying
to
new-split-spas
January 28, 2025 22:55 — with
GitHub Actions
Failure
tiffanyvu
temporarily deployed
to
new-split-spas-kibana
January 28, 2025 22:55 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
new-split-spas
January 28, 2025 22:55 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
new-split-spas-app
January 28, 2025 22:55 — with
GitHub Actions
Inactive
thwalker6
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what needs to be done to fix the test
expect(result?.statusCode).toEqual(400); | ||
}); | ||
|
||
it("should fail to split a package with no topic name", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it("should fail to split a package with no topic name", async () => {
process.env.topicName = "";
const noActionevent = {
body: JSON.stringify({
packageId: TEST_MED_SPA_ITEM._id,
}),
} as APIGatewayEvent;
expect(async () => await handler(noActionevent)).rejects.toThrow();
expect(async () => await handler(noActionevent)).rejects.toThrowError(
"Topic name is not defined",
);
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Linked Ticket
OY2-31171
💬 Description / Notes
The ability to create split SPAs is needed.
🛠 Changes
Split SPAs can only be created from Medicaid SPAs and will exist as the Medicaid SPA package ID - [capital alphabetical letter from A-Z]. Currently, we do not allow incrementing past Z.
📸 Screenshots / Demo