Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): Create split SPAs #1059

Closed
wants to merge 90 commits into from
Closed

feat(lambda): Create split SPAs #1059

wants to merge 90 commits into from

Conversation

tiffanyvu
Copy link
Collaborator

@tiffanyvu tiffanyvu commented Jan 23, 2025

🎫 Linked Ticket

OY2-31171

💬 Description / Notes

The ability to create split SPAs is needed.

🛠 Changes

Split SPAs can only be created from Medicaid SPAs and will exist as the Medicaid SPA package ID - [capital alphabetical letter from A-Z]. Currently, we do not allow incrementing past Z.

📸 Screenshots / Demo

@tiffanyvu tiffanyvu temporarily deployed to new-split-spas-kibana January 28, 2025 22:55 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to new-split-spas-app January 28, 2025 22:55 — with GitHub Actions Inactive
Copy link
Collaborator

@thwalker6 thwalker6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what needs to be done to fix the test

expect(result?.statusCode).toEqual(400);
});

it("should fail to split a package with no topic name", async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  it("should fail to split a package with no topic name", async () => {
    process.env.topicName = "";
    const noActionevent = {
      body: JSON.stringify({
        packageId: TEST_MED_SPA_ITEM._id,
      }),
    } as APIGatewayEvent;

    expect(async () => await handler(noActionevent)).rejects.toThrow();
    expect(async () => await handler(noActionevent)).rejects.toThrowError(
      "Topic name is not defined",
    );
  });

@tiffanyvu tiffanyvu closed this Jan 29, 2025
@tiffanyvu tiffanyvu deleted the split-spas branch January 29, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants