Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Bad styleguide import link #33

Merged
merged 5 commits into from
Sep 30, 2024
Merged

[fix] Bad styleguide import link #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
406f649
- Port updated Makefile steps from Java client library to fix CI
nwithan8 Sep 30, 2024
dc445dc
Revert "- Port updated Makefile steps from Java client library to fix…
nwithan8 Sep 30, 2024
b69d940
- Fix bad styleguide link
nwithan8 Sep 30, 2024
dc81c0d
- Remove styleguide from git, always import from examples repo
nwithan8 Sep 30, 2024
af31429
- Import style guide before linting on CI
nwithan8 Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ jobs:
with:
distribution: "zulu"
java-version: "23" # Always use the latest JDK for building
- name: Install dependencies
run: make install
- name: Run CheckStyle checks
uses: nikitasavinov/[email protected]
with:
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,6 @@ cassettes/

# Coverage
*.lcov

# Imported linting config
easypost_java_style.xml
Comment on lines +38 to +39
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I don't feel this is necessary to add, just reference the new one from examples

2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ coverage:
## install-checkstyle - Install CheckStyle
install-checkstyle:
curl -LJs https://github.com/checkstyle/checkstyle/releases/download/checkstyle-10.3.1/checkstyle-10.3.1-all.jar -o checkstyle.jar
curl -LJs https://raw.githubusercontent.com/EasyPost/easypost-java/master/easypost_java_style.xml -o easypost_java_style.xml
curl -LJs https://raw.githubusercontent.com/EasyPost/examples/refs/heads/master/style_guides/java/easypost_java_style.xml -o easypost_java_style.xml

## install - Install requirements
install: | install-checkstyle
Expand Down
221 changes: 0 additions & 221 deletions easypost_java_style.xml
View file
Open in desktop

This file was deleted.

Loading