Code

Add sowing window input files#2193

Code

Merged

samsrabin merged 98 commits intoESCOMP:masterESCOMP/CTSM:masterfrom samsrabin:newcropcals-rxsowwindow-03samsrabin/CTSM:newcropcals-rxsowwindow-03Copy head branch name to clipboardOct 30, 2023

+1,194-222

Commits

Commits on Jul 27, 2023

• fates cross-grid seed dispersal api update

  glemieux

  committed
  36a49a5

  Copy full SHA for 36a49a5

Commits on Aug 22, 2023

• Merge tag 'ctsm5.1.dev135' into fates-seeddispersal

  Show description for ad448d1
  glemieux

  committed
  ad448d1

  Copy full SHA for ad448d1

• change logic to fates nearest neighbor call

  Show description for 50b4e49
  glemieux

  committed
  50b4e49

  Copy full SHA for 50b4e49

• update the fates external tag

  glemieux

  committed
  8518eca

  Copy full SHA for 8518eca

Commits on Aug 23, 2023

• Merge tag 'ctsm5.1.dev136' into fates-seeddispersal

  Show description for dc1f145
  glemieux

  committed
  dc1f145

  Copy full SHA for dc1f145

• update seed dispersal per refactor

  Show description for 553023e
  glemieux

  committed
  553023e

  Copy full SHA for 553023e

Commits on Aug 24, 2023

• move nearest neighbor procedure call to fates init

  glemieux

  committed
  963d31b

  Copy full SHA for 963d31b

• encapsulate seed initalization inside disperal mode logic gate

  glemieux

  committed
  84fd8cc

  Copy full SHA for 84fd8cc

Commits on Aug 30, 2023

• update for seed dispersal restarts

  glemieux

  committed
  e978870

  Copy full SHA for e978870

Commits on Sep 1, 2023

• refactor fates dispersal MPI reduction using gather

  glemieux

  committed
  10dffb6

  Copy full SHA for 10dffb6

Commits on Sep 11, 2023

• invert dispersal type dimensions for memory continuity for mpi collective

  glemieux

  committed
  c2c108d

  Copy full SHA for c2c108d

Commits on Sep 25, 2023

• initial addition of fates seed dispersal switch and testmod

  glemieux

  committed
  5d67d04

  Copy full SHA for 5d67d04

• change the seed dispersal switch to take different values

  Show description for 2d95504
  glemieux

  committed
  2d95504

  Copy full SHA for 2d95504

• Split the fates seed dispersal ERP test into an ERS and PEM test

  glemieux

  committed
  9e69e55

  Copy full SHA for 9e69e55

Commits on Sep 26, 2023

• include gridcell history diagnostics in the dispersal test

  glemieux

  committed
  feb1833

  Copy full SHA for feb1833

• correct expected fails to match testlist update

  glemieux

  committed
  6936ac4

  Copy full SHA for 6936ac4

Commits on Sep 27, 2023

• correct cadence logic

  glemieux

  committed
  521d24e

  Copy full SHA for 521d24e

• minor corrections to some dispersal comments

  glemieux

  committed
  a7dd2e6

  Copy full SHA for a7dd2e6

• Merge branch 'master' into fates-seeddispersal

  glemieux

  committed
  7b69875

  Copy full SHA for 7b69875

• move fates seed dispersal logic gates outside the procedure to be called

  glemieux

  committed
  8190e3b

  Copy full SHA for 8190e3b

• remove old seed dispersal diagnostic write statements

  glemieux

  committed
  3f1b4e5

  Copy full SHA for 3f1b4e5

• fix incorrect seed dispersal call

  glemieux

  committed
  00a242c

  Copy full SHA for 00a242c

• fix additional seed disperal check

  glemieux

  committed
  ee97fb4

  Copy full SHA for ee97fb4

Commits on Sep 28, 2023

• fix expected failure phase name for seed dispersal pem test

  glemieux

  committed
  8875f3a

  Copy full SHA for 8875f3a

• move dispersal timing call inside cadence check

  Show description for 3f50fd6
  glemieux

  committed
  3f50fd6

  Copy full SHA for 3f50fd6

Commits on Oct 2, 2023

• fix compset name to match the expected failure list

  glemieux

  committed
  5e819a5

  Copy full SHA for 5e819a5

• remove cru from fates compset name

  glemieux

  committed
  257a33b

  Copy full SHA for 257a33b

Commits on Oct 10, 2023

• Specify stream_fldFileName_swindow_(start,end) instead of stream_fldFileName_sdate.

  Show description for 7150f84
  samsrabin

  committed
  7150f84

  Copy full SHA for 7150f84

• Added SWINDOW_STARTS and SWINDOW_ENDS outputs.

  samsrabin

  committed
  87c1d21

  Copy full SHA for 87c1d21

• CropPhenology() can now handle missed sowing windows.

  Show description for d9b7cdf
  samsrabin

  committed
  d9b7cdf

  Copy full SHA for d9b7cdf

• Prevent crops from being sown twice in one sowing window.

  samsrabin

  committed
  c3fd7f3

  Copy full SHA for c3fd7f3

• Actually USE sown_in_this_window.

  samsrabin

  committed
  1b55382

  Copy full SHA for 1b55382

• Use paramfile if either rx sowing window value is missing.

  samsrabin

  committed
  dcc55d6

  Copy full SHA for dcc55d6

• Add subroutines get_doy_tomorrow() and get_swindow(), plus unit tests.

  Show description for 6e11040
  samsrabin

  committed
  6e11040

  Copy full SHA for 6e11040

• Use get_swindow() in CropPhenology().

  Show description for 9104f88
  samsrabin

  committed
  9104f88

  Copy full SHA for 9104f88

• Added a TODO.

  samsrabin

  committed
  e5a3dc0

  Copy full SHA for e5a3dc0

• Bugfix to allow_unprescribed_planting.

  samsrabin

  committed
  b0107fd

  Copy full SHA for b0107fd

• Reverted behavior change re: HARVEST_REASON_SOWTOMORROW.

  Show description for 1693c0d
  samsrabin

  committed
  1693c0d

  Copy full SHA for 1693c0d

• Removed unused logical sowing_window_starts_tomorrow.

  samsrabin

  committed
  bb57753

  Copy full SHA for bb57753

• Resolved a TODO by thinking about it.

  samsrabin

  committed
  0585ef2

  Copy full SHA for 0585ef2

• Sowing window outputs now saved on end date.

  Show description for 0658cab
  samsrabin

  committed
  0658cab

  Copy full SHA for 0658cab

• Fail if a sowing window start date is prescribed without an end date (or vice versa).

  samsrabin

  committed
  ba014b0

  Copy full SHA for ba014b0

• Ensure that, if mxsowings > 1, sowing windows are ordered such that ENDS are monotonically increasing.

  samsrabin

  committed
  d0f77fc

  Copy full SHA for d0f77fc

• Simplified some harvest logic.

  samsrabin

  committed
  3422d51

  Copy full SHA for 3422d51

• Removed a TODO.

  samsrabin

  committed
  baed0a7

  Copy full SHA for baed0a7

• Replaced an EOL backslash with &.

  samsrabin

  committed
  5ea05d5

  Copy full SHA for 5ea05d5

• Added a comment.

  samsrabin

  committed
  fd7140e

  Copy full SHA for fd7140e

• Add function was_sown_in_this_window() to handle edge cases.

  Show description for 1cade99
  samsrabin

  committed
  1cade99

  Copy full SHA for 1cade99

• Correct a comment.

  samsrabin

  committed
  bab7848

  Copy full SHA for bab7848

• Remove an unused 'use' variable.

  samsrabin

  committed
  1669805

  Copy full SHA for 1669805

• Combined two if-blocks.

  samsrabin

  committed
  bc77099

  Copy full SHA for bc77099

• Add SWINDOW start/end dates to crop testmod.

  samsrabin

  committed
  e161bf5

  Copy full SHA for e161bf5

• Add sowingWindows testmod.

  samsrabin

  committed
  703de51

  Copy full SHA for 703de51

Commits on Oct 11, 2023

• Remove unused next_swindow_start from get_swindow().

  samsrabin

  committed
  30f47a5

  Copy full SHA for 30f47a5

• Change check for invalid dates in get_swindow().

  samsrabin

  committed
  df30d04

  Copy full SHA for df30d04

• Improve comments in get_swindow().

  samsrabin

  committed
  18c9eeb

  Copy full SHA for 18c9eeb

Commits on Oct 12, 2023

• align operators to the ctsm style guide

  glemieux

  committed
  27af410

  Copy full SHA for 27af410

• add clarifying comments to the fates seed dispersal code

  glemieux

  committed
  85b7537

  Copy full SHA for 85b7537

• minor comment reword

  glemieux

  committed
  570fd19

  Copy full SHA for 570fd19

Commits on Oct 13, 2023

• rename fates set_flag

  glemieux

  committed
  32acc65

  Copy full SHA for 32acc65

Commits on Oct 17, 2023

• Comment fixes and improvements.

  samsrabin

  committed
  f058160

  Copy full SHA for f058160

• CropType: Don't allocate things twice.

  samsrabin

  committed
  951eed4

  Copy full SHA for 951eed4

• Add input validity check to get_doy_tomorrow().

  samsrabin

  committed
  90bbb16

  Copy full SHA for 90bbb16

• Don't use hardcoded 365 in cropcalStreamMod.

  samsrabin

  committed
  92b5435

  Copy full SHA for 92b5435

• do_plant_prescribed: Check sown_in_this_window, not sowing_count.

  samsrabin

  committed
  8d1537c

  Copy full SHA for 8d1537c

• update fates seed dispersal test mod

  Show description for 2896889
  glemieux

  committed
  2896889

  Copy full SHA for 2896889

• Remove unneeded check in cropcal_interp().

  samsrabin

  committed
  bc148eb

  Copy full SHA for bc148eb

• Remove some commented-out lines from cropcal_interp().

  samsrabin

  committed
  96a47bd

  Copy full SHA for 96a47bd

Commits on Oct 18, 2023

• Updated paths in sowingWindows/user_nl_clm.

  samsrabin

  committed
  6081633

  Copy full SHA for 6081633

• Require allow_invalid_swindow_inputs to avoid error on invalid sowing window read.

  samsrabin

  committed
  16b73f1

  Copy full SHA for 16b73f1

• Only error on invalid swindow if wtgcell > 0.

  samsrabin

  committed
  e71e8e7

  Copy full SHA for e71e8e7

• update fates seed dispersal subroutine names

  glemieux

  committed
  b90040f

  Copy full SHA for b90040f

• Only error on invalid swindow if patch is prognostic crop.

  samsrabin

  committed
  52d665f

  Copy full SHA for 52d665f

• List crop types with invalid swindows.

  samsrabin

  committed
  ce7e9ec

  Copy full SHA for ce7e9ec

• Merge tag 'ctsm5.1.dev143' into fates-seeddispersal

  Show description for e4dbdaf
  glemieux

  committed
  e4dbdaf

  Copy full SHA for e4dbdaf

• update testmod to place nc generated file into SRCROOT

  glemieux

  committed
  899212e

  Copy full SHA for 899212e

• update fates external

  glemieux

  committed
  c49a222

  Copy full SHA for c49a222

• move dispersal timing check function outside of site loop

  glemieux

  committed
  7226823

  Copy full SHA for 7226823

• move beginning day check inside the global seed dispersal subroutine

  glemieux

  committed
  c5711f7

  Copy full SHA for c5711f7

• fix base rebase, rename dispersal subroutines

  glemieux

  committed
  c811ae9

  Copy full SHA for c811ae9

Commits on Oct 19, 2023

• add threaded region check to seed dispersal call

  glemieux

  committed
  732d3b9

  Copy full SHA for 732d3b9

• remove temporary write statement

  glemieux

  committed
  6953572

  Copy full SHA for 6953572

• Update fates external

  glemieux

  committed
  b338b26

  Copy full SHA for b338b26

Commits on Oct 20, 2023

• Merge tag 'ctsm5.1.dev145' into fates-seeddispersal

  Show description for c5be73b
  glemieux

  committed
  c5be73b

  Copy full SHA for c5be73b

Commits on Oct 23, 2023

• update changelog and changesum for ctsm5.1.dev145

  

  glemieux

  committed
  5a2e0ff

  Copy full SHA for 5a2e0ff

Commits on Oct 25, 2023

• Update date

  ekluzek

  committed
  121d77c

  Copy full SHA for 121d77c

Commits on Oct 26, 2023

• Removed a TODO.

  samsrabin

  committed
  5cb70af

  Copy full SHA for 5cb70af

• Fix bug in was_sown_in_this_window() for windows w/ start==end.

  samsrabin

  committed
  d783396

  Copy full SHA for d783396

Commits on Oct 27, 2023

• More precise error check in get_doy_tomorrow().

  samsrabin

  committed
  54e5f24

  Copy full SHA for 54e5f24

• Merge tag 'ctsm5.1.dev146' into newcropcals-rxsowwindow-03

  Show description for e65b6b0
  samsrabin

  committed
  e65b6b0

  Copy full SHA for e65b6b0

• Added entries in ChangeLog and ChangeSum.

  samsrabin

  committed
  99e0b91

  Copy full SHA for 99e0b91

• Fix formatting in a write() call.

  samsrabin

  committed
  e212bc9

  Copy full SHA for e212bc9

Commits on Oct 30, 2023

• Centralize defs of secs_in_day & dtime in test_clm_time_manager.

  samsrabin

  committed
  80a01b0

  Copy full SHA for 80a01b0

• Better handling of days in year.

  samsrabin

  committed
  31d8492

  Copy full SHA for 31d8492

• Add leap-year test of get_doy_tomorrow().

  samsrabin

  committed
  818f3ce

  Copy full SHA for 818f3ce

• get_doy_tomorrow(): Use get_prev_days_per_year() instead of _curr_.

  samsrabin

  committed
  c803fea

  Copy full SHA for c803fea

• Explain use of get_prev_days_per_year().

  samsrabin

  committed
  0bcec66

  Copy full SHA for 0bcec66

• Update ChangeLog and ChangeSum.

  samsrabin

  committed
  806f124

  Copy full SHA for 806f124