Add sowing window input files #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename hist fields to track them down more easily Renaming history fields to make easier to find in lists, e.g. when using ncview. For example, litter fields like MET_LIT and STR_LIT will be LIT_MET and LIT_STR.
If fates is not using dispersal mode, which is set via the parameter file, do not run the nearest neighbor algorithm to avoid performace impact.
Change order of history fields to improve performance on derecho Instead of just ordering history fields alphabetically, order them first by the name of their level dimension (with fields without a level dimension appearing first), then alphabetically within a given level dimension. This changed ordering gives a significant performance improvement especially noticeable on lustre file systems such as on derecho.
This corresponds to a fates-side refactor that moves the seed_out and seed_in variables from the bc_in/out types to site. Corrections to the column type names are also made
Since fates seed dispersal can occur at different user defined cadences, allow the user to define this via the namelist.
The dispersal timing call utilizes a function that is not initialized unless the mode has been initialized. If it is included along with the cadence check as it was setup previously, the timing call will fail having not been initialized.
…ileName_sdate. * Replicate stream_fldFileName_sdate behavior by using same file for stream_fldFileName_swindow_start and stream_fldFileName_swindow_end. * RXCROPMATURITY test looks fine.
# Conflicts: # src/biogeochem/CNPhenologyMod.F90
SNICAR snow albedo scheme updates A few substantial changes in the SNICAR module for the following updated snow albedo calculation features: - Updated ice optical properties from Flanner et al. (2021), with multiple types for ice refractive indices. - Updated aerosol optical properties from Flanner et al. (2021) with multiple dust types & new BC and OC optics. - Updated downward solar spectra from Flanner et al. (2021) for multiple condition types. - More accurate radiative transfer solver (adding-doubling) from Dang et al. (2019). - Nonspherical snow grain scheme from He et al. (2017). - BC-snow internal mixing scheme from He et al. (2017). - Dust-snow internal mixing scheme from He et al. (2019). - Hyperspectral (480-band, 10-nm spectral res) capability with all the above features. - New namelist controls for aerosol in snow and additional snow albedo diagnostic output variables. Specific notes - Code contributors: Cenlin He (NCAR/RAL) with advice from Dave Lawrence (NCAR/CGD) and Mark Flanner (UMich). - The manuscript to report this update is Cenlin He, Mark Flanner, David M Lawrence, Yu Gu: New features and enhancements in Community Land Model (CLM5) snow albedo modeling: description, sensitivity, and evaluation. Authorea. June 08, 2023. DOI:10.22541/essoar.168626390.01530324/v1 - These updates will change the snow and surface albedo results along with other surface fluxes changes. - There are a few new namelist options related to SNICAR scheme added to the namelist control. New namelist variables: snicar_numrad_snw = 5 or 480 wavelength bands, default 5 snicar_solarspec, default "mid_latitude_winter" among six available options snicar_dust_optics, default "sahara" among three avail. options snicar_snw_shape, default "hexagonal_plate" among fourn avail. options snicar_use_aerosol, default .true. snicar_snobc_intmix and snicar_snodst_intmix, default .false. means do not activate bc-snow and dust-snow internal mixing do_sno_oc, default .false., already appeared in previous code but in caps use_snicar_frc, default .false., existed before fsnowoptics now points to an updated 5-band file and gives the option for a 480-band file
|
8d1537c broke RXCROPMATURITY; investigating. |
|
@slevis-lmwg Ready for re-review! Everything should be self-explanatory, but if you'd like to go through the diffs together, let me know. After review, I will
|
slevis-lmwg
requested changes
Oct 27, 2023
There was a problem hiding this comment.
@samsrabin you will find one more request before I approve. Also I think it would be best if we went over things together in a 30' meeting today or Monday.
src/utils/clm_time_manager.F90
Outdated
| integer :: doy_tomorrow | ||
| character(len=*), parameter :: sub = 'clm::get_doy_tomorrow' | ||
|
|
||
| if ( doy_today < 1 .or. doy_today > 367 )then |
There was a problem hiding this comment.
Why 367? Is it 367 in leap years only? If so, I suggest replacing 367 with curr_days_per_year + 1 and explaining why + 1 in a comment.
There was a problem hiding this comment.
Good point. I don't know why it was EVER 367; fixed in 54e5f24.
slevis-lmwg
approved these changes
Oct 27, 2023
FATES cross-grid seed dispersal This PR enables FATES to disperse seeds across neighboring grid cells using MPI. The API update includes calls to new fates dispersal procedures. There are four parameters that are utilized to control the dispersal kernel, although these were introduced in ctsm5.1.dev130 so no new default FATES parameter file is necessary with this update. A new namelist parameter has been added to enable the use of the seed dispersal mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Previously, one could run crops with either (a) sowing windows defined by the hemisphere-specific start and end dates on the paramfile or (b) prescribed sowing dates specified by input file
stream_fldFileName_sdate. This PR replaces the latter with two new input files,stream_fldFileName_swindow_startandstream_fldFileName_swindow_end.Specific notes
sowingDatestestmod, which uses sowing windows derived from the static GGCMI phase 3 crop calendar dataset.Contributors other than yourself, if any: None
CTSM Issues Fixed (include github issue #): None
Are answers expected to change (and if so in what way)? No.
Any User Interface Changes (namelist or namelist defaults changes)? Removes namelist parameter
stream_fldFileName_sdate. Adds namelist parametersstream_fldFileName_swindow_startandstream_fldFileName_swindow_end.Testing performed, if any: A version of 1cade99 with some additional verbosity passed
aux_clmagainstctsm5.1.dev142.RXCROPMATURITYtest also works.