Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_048: Timestamp in rpointer name #1147

Merged

Conversation

jedwards4b
Copy link

Add a timestamp in the rpointer name.
This is a backward compatible change in that rpointer.cam will still work
but new files will include a timestamp.
Fixes #1146

@jedwards4b jedwards4b marked this pull request as draft September 11, 2024 20:19
@cacraigucar cacraigucar added the misc tag issue or PR candidate for upcoming misc tag label Sep 17, 2024
@jedwards4b jedwards4b marked this pull request as ready for review October 3, 2024 16:36
Copy link
Collaborator

@brian-eaton brian-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments and a question

src/control/cam_comp.F90 Outdated Show resolved Hide resolved
src/control/cam_initfiles.F90 Outdated Show resolved Hide resolved
src/control/runtime_opts.F90 Outdated Show resolved Hide resolved
src/cpl/nuopc/atm_comp_nuopc.F90 Show resolved Hide resolved
@jedwards4b jedwards4b requested a review from brian-eaton October 3, 2024 17:49
Copy link
Collaborator

@brian-eaton brian-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

@jedwards4b jedwards4b force-pushed the timestamp_in_rpointer_name branch from 4ed77db to 0007c77 Compare October 29, 2024 13:55
@jedwards4b
Copy link
Author

I'm not sure what happened to the history here. I rebased to cam_development tag: cam6_4_043 and pushed back. Now this PR shows my changes applied twice, but git log in my sandbox does not show the original commits.

@peverwhee peverwhee removed the misc tag issue or PR candidate for upcoming misc tag label Nov 12, 2024
@peverwhee peverwhee changed the title Timestamp in rpointer name cam6_4_047: Timestamp in rpointer name Nov 12, 2024
@peverwhee peverwhee self-assigned this Nov 12, 2024
@peverwhee peverwhee changed the title cam6_4_047: Timestamp in rpointer name cam6_4_048: Timestamp in rpointer name Nov 13, 2024
@ekluzek ekluzek added the externals externals updating issue or PR label Dec 17, 2024
@ekluzek
Copy link

ekluzek commented Dec 17, 2024

This is dependent on the CTSM tag, and updates to: cime, share, cmeps and cdeps.

@peverwhee on Izumi you'll need to update cdeps to cdeps1.0.61, otherwise you'll find problems with the CDEPS tests.

@peverwhee peverwhee merged commit f429ebf into ESCOMP:cam_development Dec 20, 2024
2 checks passed
JulioTBacmeister added a commit to JulioTBacmeister/CAM that referenced this pull request Dec 23, 2024
Merge pull request ESCOMP#1147 from jedwards4b/timestamp_in_rpointer_name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
externals externals updating issue or PR
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

5 participants