-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve popup on special pages #1737
Conversation
@lemnis @andresbase I have not tested on Android, I hope this doesn't break anything. |
Need to fix (or disable, maybe until #1634) popup tests. The problem is that the popup is opened in a situation that looks like a special browser page, so that site whitelisting and error reporting buttons as well as the trackers link are now missing. They should be, but the tests still look for them. |
@andresbase Sorry, I added a few potentially breaking changes while fixing tests; we should retest. |
To avoid inconsistent display/various popup bugs.
We now use the same function to build the tabData datastructure everywhere. We also build it for all tabs in all windows on boot up. Previously we were just building it for tabs in the current window. So if you had a background console open to PB, and refreshed with Ctrl+R, it would not build the tabData for the tabs in the other windows. This was causing errors like "Cannot read property "trackers" of undefined."
Popup now gets closed instead.
243eb75
to
03004f0
Compare
732d9e2
to
e4be4d3
Compare
This fixes the deactivation button being shown on special browser pages.
e4be4d3
to
a202784
Compare
Tests in macOS, Windows 10, Linux with Chrome and FF Latest versions:
|
I was also thinking that the text "There are no third party resources on this site." could be larger or bold so it stands out from all the other text above it that says the usual "Privacy Badger detected 0..." For the largo logo after inquiring with other people it seems it looks ok while we redesign the UI. |
What are the steps to reproduce? |
I just installed PB in Firefox 56 and hover over the border when you click on the PB icon. |
I can't reproduce. Could it be that you installed Badger from a branch that doesn't have the new translation strings used in your screenshot, and then switched branches but didn't reload Badger in the browser? Translations are loaded on Badger startup only. A few files (popup.html, popup.js, options.html, options.js) don't seem to require reloading to see new versions of, but most everything else does. |
Indeed, that must have been the problem, thanks! I can't reproduce the performance issues anywhere else either. They are persistent in my work machine but nowhere else. |
Hide irrelevant text/buttons on special browser pages. Close popup after doing anything that reloads the page.
Fixes #1625.
Fixes #1311, fixes #1492 by virtue of reloading the popup after clicking the undo arrow (as well as the enable/disable Badger buttons). This doesn't need to be in this PR; if it causes trouble, let's break it out.
Related to #1627.
Does not fix:
chrome://extensions
(or Chrome Web Store, orabout:debugging
in Firefox, ...) as a special browser pageBefore:
After: