Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted popup scrollbars in Firefox #1610

Closed
ghostwords opened this issue Aug 28, 2017 · 4 comments
Closed

Unwanted popup scrollbars in Firefox #1610

ghostwords opened this issue Aug 28, 2017 · 4 comments
Labels
bug Firefox good first issue help wanted ui User interface modifications; related to but not the same as the "ux" label

Comments

@ghostwords
Copy link
Member

screenshot from 2017-08-22 17 03 07

From #1516 (comment).

@ghostwords ghostwords added bug Firefox help wanted ui User interface modifications; related to but not the same as the "ux" label labels Aug 28, 2017
@lemnis
Copy link
Contributor

lemnis commented Aug 29, 2017

I'm unable to reproduce this issue, could you give me some extra info (which site, used OS, etc.) ?

@ghostwords
Copy link
Member Author

Firefox 55.0.2 on Linux. Can reproduce by opening Firefox with a fresh profile, installing Privacy Badger from master, visiting cnn.com (or any site with enough third-party domains) and opening the popup.

@ghostwords ghostwords changed the title Popup scrollbar in case of long-enough domain lists in Firefox Unwanted popup scrollbars in Firefox Oct 19, 2017
@ghostwords
Copy link
Member Author

ghostwords commented Oct 19, 2017

I can't reproduce on pages with many third-party domains anymore, but I can reproduce in the popup on whitelisted sites (screenshot below) and also on special browser pages (in the #1737 branch).

screenshot from 2017-10-19 14 52 48

@lemnis
Copy link
Contributor

lemnis commented Oct 19, 2017

I tested before in macOS and in elementary os (fork of ubuntu) and couldn't reproduce it.

It can occur when firefox finished its height calculation before it stop rendering. I only saw this occur when trying the fork in #1445 with flexbox, but I believe it can also occur with calc() and
display: grid;.
Maybe I should create a bug report at bugzilla for above issue, but I didn't bother till now. It's a pretty rare case.

A possible solution could be found while cleaning up popup.css, every time I look at I see css that could be coded neater.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Firefox good first issue help wanted ui User interface modifications; related to but not the same as the "ux" label
Projects
None yet
Development

No branches or pull requests

2 participants