Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] use StateObject instead of ObservedObject #1139

Merged
merged 1 commit into from
Sep 10, 2023
Merged

[iOS] use StateObject instead of ObservedObject #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app-ios/Modules/Sources/Contributor/ContributorView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public struct ContributorView: View {
}

struct ContributorSwiftUIView: View {
@ObservedObject var viewModel: ContributorViewModel = .init()
@StateObject var viewModel: ContributorViewModel = .init()
let onContributorItemClick: (String) -> Void

var body: some View {
Expand Down
2 changes: 1 addition & 1 deletion app-ios/Modules/Sources/FloorMap/FloorMapView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import SwiftUI
import Theme

public struct FloorMapView: View {
@ObservedObject var viewModel: FloorMapViewModel = .init()
@StateObject var viewModel: FloorMapViewModel = .init()
@State private var floor: FloorLevel = .ground

public init() {}
Expand Down
2 changes: 1 addition & 1 deletion app-ios/Modules/Sources/Navigation/RootView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ enum Tab {
}

public struct RootView: View {
@ObservedObject var viewModel: RootViewModel = .init()
@StateObject var viewModel: RootViewModel = .init()
@State var selection = Tab.timeline

public init() {}
Expand Down
2 changes: 1 addition & 1 deletion app-ios/Modules/Sources/Sponsor/SponsorView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import SwiftUI
import Theme

public struct SponsorView: View {
@ObservedObject var viewModel: SponsorViewModel = .init()
@StateObject var viewModel: SponsorViewModel = .init()

public init() {}

Expand Down
2 changes: 1 addition & 1 deletion app-ios/Modules/Sources/Staff/StaffView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import SwiftUI

public struct StaffView: View {
@State var presentingURL: IdentifiableURL?
@ObservedObject var viewModel: StaffViewModel = .init()
@StateObject var viewModel: StaffViewModel = .init()

public init() {}

Expand Down
2 changes: 1 addition & 1 deletion app-ios/Modules/Sources/Timetable/Bookmark/BookmarkView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ enum BookmarkRouting: Hashable {
}

struct BookmarkView<SessionView: View>: View {
@ObservedObject var viewModel: BookmarkViewModel = .init()
@StateObject var viewModel: BookmarkViewModel = .init()
private let sessionViewBuilder: ViewProvider<TimetableItem, SessionView>

public init(sessionViewBuilder: @escaping ViewProvider<TimetableItem, SessionView>) {
Expand Down
2 changes: 1 addition & 1 deletion app-ios/Modules/Sources/Timetable/Search/SearchView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ enum SearchRouting: Hashable {
}

struct SearchView<SessionView: View>: View {
@ObservedObject var viewModel: SearchViewModel = .init()
@StateObject var viewModel: SearchViewModel = .init()
private let sessionViewBuilder: ViewProvider<TimetableItem, SessionView>

public init(sessionViewBuilder: @escaping ViewProvider<TimetableItem, SessionView>) {
Expand Down
2 changes: 1 addition & 1 deletion app-ios/Modules/Sources/Timetable/TimetableView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ enum TimetableRouting: Hashable {

public struct TimetableView<SessionView: View>: View {
@Environment(\.colorScheme) var colorScheme
@ObservedObject var viewModel: TimetableViewModel = .init()
@StateObject var viewModel: TimetableViewModel = .init()
private let sessionViewBuilder: ViewProvider<TimetableItem, SessionView>
let gradient = Gradient(stops: [
.init(color: AssetColors.Surface.surfaceGradientTOP.swiftUIColor, location: 0.0),
Expand Down
Loading