Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] use StateObject instead of ObservedObject #1139

Merged
merged 1 commit into from
Sep 10, 2023
Merged

[iOS] use StateObject instead of ObservedObject #1139

merged 1 commit into from
Sep 10, 2023

Conversation

ry-itto
Copy link
Member

@ry-itto ry-itto commented Sep 9, 2023 •
edited
Loading

Issue

Overview (Required)

  • Currently, iOS App loads every time if each view opened. This PR improves that behavior. (If some view opened at second time, it will not reload state.)

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@ry-itto ry-itto requested a review from a team as a code owner September 9, 2023 17:36
RyuNen344
RyuNen344 approved these changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@RyuNen344 RyuNen344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😉

@ry-itto ry-itto merged commit 67a47cb into main Sep 10, 2023
4 checks passed
@ry-itto ry-itto deleted the ios-improve-open-view-loading branch September 10, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyuNen344 RyuNen344 RyuNen344 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] Improve ViewModel load timing for all pages
2 participants
@ry-itto @RyuNen344