Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation from Github for upstream packages #174

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

AlexanderWells-diamond
Copy link
Collaborator

Fixes #147

@AlexanderWells-diamond
Copy link
Collaborator Author

This PR is on hold pending proper, non-alpha, releases of pvxslibs, p4p and epicscorelibs as currently there seems to be a weird dependency mismatch. Trying to install these three projects from their respective master branches results in an error:

pip install git+https://github.com/epics-base/epicscorelibs.git git+https://github.com/epics-base/pvxs.git git+https://github.com/epics-base/p4p.git
...
...
  ERROR: Cannot install epicscorelibs 7.0.7.99.1.1a3 (from git+https://github.com/epics-base/epicscorelibs.git), p4p==4.2.0a3 and pvxslibs==1.3.2a2 because these package versions have conflicting dependencies.
  
  The conflict is caused by:
      The user requested epicscorelibs 7.0.7.99.1.1a3 (from git+https://github.com/epics-base/epicscorelibs.git)
      pvxslibs 1.3.2a2 depends on epicscorelibs<7.0.7.99.2 and >=7.0.7.99.1.1a3
  ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
      p4p 4.2.0a3 depends on epicscorelibs<7.0.7.99.1 and >=7.0.7.99.0.2

It's weird as it seems that p4p and pvxslibs have the same dependency statement on epicscorelibs: epicscorelibs.version.abi_requires(), so I don't see why they are getting different dependency requirements.

@AlexanderWells-diamond AlexanderWells-diamond force-pushed the test_upstream_master_branches branch 2 times, most recently from bd80353 to 970f0d9 Compare September 27, 2024 12:55
@AlexanderWells-diamond
Copy link
Collaborator Author

AlexanderWells-diamond commented Sep 27, 2024

I think my previous comment was misinformed: The issue is actually a possible discrepancy between build-time and run-time requirements of p4p (more specifically in the pvxslibs dependency that is pulled in wanting an older epicscorelibs version). By being careful with installation order and using the no-warn-conflicts flag I can bypass the issue and still get a working CI test run.

@OCopping @mdavidsaver Does this look OK to you? Anything else you would want to see in an integration test of the various Python libraries?

Note that the Windows + Python3.12 build issue should be fixed once Numpy does another release

@AlexanderWells-diamond
Copy link
Collaborator Author

AlexanderWells-diamond commented Nov 5, 2024

Running into an issue with epicscorelibs version checking of cothread. Potential solution in this PR

This should allow us to spot upcoming issues before releases are made.
Done as part of a request from Michael Davidsaver.
@AlexanderWells-diamond AlexanderWells-diamond merged commit cc73fd8 into master Nov 6, 2024
41 checks passed
@AlexanderWells-diamond AlexanderWells-diamond deleted the test_upstream_master_branches branch November 6, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI builds using main branch of epicscorelibs, pvxs, and p4p
1 participant