1.3.2 #83
Merged
1.3.2 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCopping
requested review from
mdavidsaver,
AlexanderWells-diamond and
coretl
AlexanderWells-diamond
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Doing a full release of this and all other Python packages sounds good to me.
I think you are missing some changes, see the previous release commit here: 93ab81c
The test for this is currently waiting review here: DiamondLightSource/pythonSoftIOC#174
AlexanderWells-diamond
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have tested this works, I propose we release it proper.