Move methods database from httomo to httomo-backends #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namannimmo10
force-pushed
the
methodsdtbs
branch
from
b9d669b to
f067e6b
Compare
|
Tests currently failing locally. WIP. |
No worries, there's a helpful "draft state" for a PR if it's not ready for reviewing (and is a decent way to prevent merging the PR before it's ready), you can change the state of the PR to a draft in the "Reviewers" section in the top right by clicking "Convert to draft": |
namannimmo10
force-pushed
the
methodsdtbs
branch
5 times, most recently
from
d7252f7 to
141ceb0
Compare
yousefmoazzam
force-pushed
the
methodsdtbs
branch
from
8d76ba8 to
72e5256
Compare
This avoids the following warning when running tests: ``` PytestUnknownMarkWarning: Unknown pytest.mark.cupy ```
Reflects the change made to the list of CuFFT versions in DiamondLightSource/httomo#531.
CI should test the version of `httomo-backends` in the branch associated with the PR, not an older version of `httomo-backends` from PyPI.
yousefmoazzam
force-pushed
the
methodsdtbs
branch
from
9f8dd3f to
3d5f2b4
Compare
This won't be necessary when the following issue is resolved in `httomolibgpu`: DiamondLightSource/httomolibgpu#170.
yousefmoazzam
force-pushed
the
methodsdtbs
branch
from
3d5f2b4 to
86bb2b0
Compare
This won't be necessary when the following issue is resolved in `httomolibgpu`: DiamondLightSource/httomolibgpu#171
yousefmoazzam
force-pushed
the
methodsdtbs
branch
7 times, most recently
from
68a1f36 to
1a31451
Compare
This was referenced Dec 16, 2024
yousefmoazzam
force-pushed
the
methodsdtbs
branch
2 times, most recently
from
ef1822c to
37c37d7
Compare
yousefmoazzam
force-pushed
the
methodsdtbs
branch
from
37c37d7 to
1faa98c
Compare
This is for the raven filter's state at the following commit in `httomolibgpu`: https://github.com/DiamondLightSource/httomolibgpu/tree/66ce152a91abd474ed64f7a11b2bf59e03bb5b51
yousefmoazzam
force-pushed
the
methodsdtbs
branch
from
1faa98c to
45992e6
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.