-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py39 upgrade #5128
Py39 upgrade #5128
Conversation
eea783f
to
27d17ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR isn't feasible to review in detail by hand. But what I've seen of it looks plausible.
I think we need to get CI passing and then we can merge (NOT squash).
Set, | ||
Union, | ||
cast) | ||
from typing import Any, ContextManager, NamedTuple, Optional, Union, cast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want these imports that change constantly like this to be the multi-line form?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is black
s doing, from make format
please MERGE not SQUASH, so that the noisy commits can be ignored
Changelog Entry
To be copied to the draft changelog by merger:
black
.Reviewer Checklist
issues/XXXX-fix-the-thing
in the Toil repo, or from an external repo.camelCase
that want to be insnake_case
.docs/running/{cliOptions,cwl,wdl}.rst
Merger Checklist