Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py39 upgrade #5128

Merged
merged 13 commits into from
Oct 23, 2024
Merged

Py39 upgrade #5128

merged 13 commits into from
Oct 23, 2024

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Oct 19, 2024

please MERGE not SQUASH, so that the noisy commits can be ignored

Changelog Entry

To be copied to the draft changelog by merger:

  • Code was updated to be more idiomatic Python 3.9, and reformatted using black.

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passes tests.
  • Make sure the PR has been reviewed since its last modification. If not, review it.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

@mr-c mr-c force-pushed the py39-upgrade branch 2 times, most recently from eea783f to 27d17ca Compare October 21, 2024 07:21
@mr-c mr-c mentioned this pull request Oct 21, 2024
19 tasks
Base automatically changed from issues/5125-remove-python3.8 to master October 22, 2024 02:07
Copy link
Member

@adamnovak adamnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR isn't feasible to review in detail by hand. But what I've seen of it looks plausible.

I think we need to get CI passing and then we can merge (NOT squash).

Set,
Union,
cast)
from typing import Any, ContextManager, NamedTuple, Optional, Union, cast
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want these imports that change constantly like this to be the multi-line form?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blacks doing, from make format

@mr-c mr-c merged commit 4d0a11e into master Oct 23, 2024
1 check passed
@mr-c mr-c deleted the py39-upgrade branch October 23, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants