Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python3.8 testing. #5126

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

DailyDreaming
Copy link
Member

We've reached End of Life for python3.8.

Changelog Entry

To be copied to the draft changelog by merger:

  • PR submitter writes their recommendation for a changelog entry here

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passes tests.
  • Make sure the PR has been reviewed since its last modification. If not, review it.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

@DailyDreaming DailyDreaming marked this pull request as ready for review October 18, 2024 18:22
@mr-c
Copy link
Contributor

mr-c commented Oct 19, 2024

Woohoo! Shall I add a commit with the result of running pyupgrade --py39-plus on the entire codebase?

See #5128 for a preview (but please merge the commits, do not squash them)

Copy link
Contributor

@stxue1 stxue1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI died but it looks good to me

@DailyDreaming
Copy link
Member Author

Woohoo! Shall I add a commit with the result of running pyupgrade --py39-plus on the entire codebase?

See #5128 for a preview (but please merge the commits, do not squash them)

I'll bring #5128 up tomorrow with Adam. Thanks for suggesting it.

@DailyDreaming DailyDreaming merged commit d9d732e into master Oct 22, 2024
1 check failed
@DailyDreaming DailyDreaming deleted the issues/5125-remove-python3.8 branch October 22, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants