Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating reco workflows for opdet deconvolution #145

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Updating reco workflows for opdet deconvolution #145

wants to merge 1 commit into from

Conversation

vpec0
Copy link
Member

@vpec0 vpec0 commented Nov 7, 2024 •
edited
Loading

Updating reco workflows for opdet deconvolution to use configuration tables specific for the detector.

This PR depends on DUNE/duneopdet#69.

@vpec0
Copy link
Member Author

vpec0 commented Nov 7, 2024

There are also these files which refer to dune_deconvolution table:

vdcoldbox/reco/crp6_data_reco_daphne_bde2.fcl
vdcoldbox/reco/crp6_data_reco_daphne_bde3.fcl

I don't know how they are used and if changes are needed there.

absolution1
absolution1 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@absolution1 absolution1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We should trigger the CI before merging though.

jroto
jroto approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@jroto jroto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

lpaulucc
lpaulucc approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@lpaulucc lpaulucc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that, Viktor! Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpaulucc lpaulucc lpaulucc approved these changes

@jroto jroto jroto approved these changes

@absolution1 absolution1 absolution1 approved these changes

@calcuttj calcuttj Awaiting requested review from calcuttj

@mantheys mantheys Awaiting requested review from mantheys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vpec0 @absolution1 @jroto @lpaulucc