Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Fixes #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Small Fixes #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81d38f9
Fix kaguya json
acpaquette Nov 7, 2023
221f168
Change ck cell size by 2x and spk cells by 4x
acpaquette Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion SpiceQL/db/kaguya.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,11 @@
]
},
"spk": {
"reconstructed": {
"kernels": ["SEL_M_071020_090610_SGMH_02.BSP"]
},
"smithed": {
"kernels": ["SEL_M_[0-9]{6}_[0-9]{6}_SGMI_05.BSP",
"SEL_M_071020_090610_SGMH_02.BSP",
"SELMAINGRGM900CL660DIRALT2008103020090610.bsp"]
}
},
Expand Down
8 changes: 4 additions & 4 deletions SpiceQL/src/utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,17 +962,17 @@ namespace SpiceQL {
vector<pair<double, double>> times;
//find the correct coverage window
if(currFile == "SPK") {
SPICEDOUBLE_CELL(cover, 1000);
SPICEDOUBLE_CELL(cover, 4000);
ssize_c(0, &cover);
ssize_c(1000, &cover);
ssize_c(4000, &cover);
spkcov_c(kpath.c_str(), body, &cover);
times = formatIntervals(cover);
}
else if(currFile == "CK") {
// 200,000 is the max coverage window size for a CK kernel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the comment to reflect 2,000 as the max coverage window size for a ck kernel?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment is still correct, I can add that we are only making a 2000 element cell

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think she means the line:

// 200,000 is the max coverage window size for a CK kernel

in which case it's still accurate as 200k is the absolute max? I tried verifying this but couldnt anything in NAIFs docs that mention the maximum size.

SPICEDOUBLE_CELL(cover, 1000);
SPICEDOUBLE_CELL(cover, 2000);
ssize_c(0, &cover);
ssize_c(1000, &cover);
ssize_c(2000, &cover);

// A SPICE SEGMENT is composed of SPICE INTERVALS
ckcov_c(kpath.c_str(), body, SPICEFALSE, "SEGMENT", 0.0, "TDB", &cover);
Expand Down