Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Fixes #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Small Fixes #8

wants to merge 2 commits into from

Conversation

acpaquette
Copy link
Collaborator

  • Fixes the kaguya json file
  • Adjusts the cell sizes for the time coverage windows (2x for cks and 4x for spks)

chkim-usgs
chkim-usgs reviewed Nov 14, 2023
View reviewed changes
SpiceQL/src/utils.cpp
ssize_c(0, &cover);
ssize_c(1000, &cover);
ssize_c(4000, &cover);
spkcov_c(kpath.c_str(), body, &cover);
times = formatIntervals(cover);
}
else if(currFile == "CK") {
// 200,000 is the max coverage window size for a CK kernel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the comment to reflect 2,000 as the max coverage window size for a ck kernel?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment is still correct, I can add that we are only making a 2000 element cell

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think she means the line:

// 200,000 is the max coverage window size for a CK kernel

in which case it's still accurate as 200k is the absolute max? I tried verifying this but couldnt anything in NAIFs docs that mention the maximum size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chkim-usgs chkim-usgs chkim-usgs left review comments

@Kelvinrr Kelvinrr Awaiting requested review from Kelvinrr

@amystamile-usgs amystamile-usgs Awaiting requested review from amystamile-usgs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acpaquette @Kelvinrr @chkim-usgs